Skip to content

Actually show deprecation warnings and their line level [2/2]#8002

Merged
carmocca merged 20 commits intomasterfrom
bugfix/fix-deprecation-warnings
Jun 21, 2021
Merged

Actually show deprecation warnings and their line level [2/2]#8002
carmocca merged 20 commits intomasterfrom
bugfix/fix-deprecation-warnings

Conversation

@carmocca
Copy link
Copy Markdown
Contributor

@carmocca carmocca commented Jun 16, 2021 •
edited
Loading

What does this PR do?

Issue

DeprecationWarnings weren't being shown for two reasons:

  1. Need to set the stacklevel
  2. DeprecationWarnings needed to be enabled

Solution

  • Set the appropriate stacklevel for most calls
  • Creates our own LightningDeprecationWarning and enable it
  • Groups warning-related functions into warnings.py
  • Add a stderr special test for warnings

To decide

Since DeprecationWarnings haven't been shown, we need to decide if we should delay their removal versions.

Option 👀 : do nothing - an argument is that we already mention what's been deprecated in the release notes
Option 🚀 : Only delay the removal version of warnings set to be removed in 1.4
Option ❤️ : Do it for all

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added bug Something isn't working priority: 0 High priority task labels Jun 16, 2021
@carmocca carmocca self-assigned this Jun 16, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 16, 2021 •
edited
Loading

Codecov Report

Merging #8002 (fa74779) into master (a23a699) will decrease coverage by 5%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #8002    +/-   ##
=======================================
- Coverage      92%     87%    -5%     
=======================================
  Files         207     210     +3     
  Lines       13497   13590    +93     
=======================================
- Hits        12367   11821   -546     
- Misses       1130    1769   +639

@justusschock justusschock mentioned this pull request Jun 17, 2021
Merged
6 tasks
@carmocca carmocca changed the title [WIP] Actually show deprecation warnings and their line level [WIP] Actually show deprecation warnings and their line level [2/2] Jun 18, 2021
@carmocca carmocca mentioned this pull request Jun 18, 2021
Merged
11 tasks
@carmocca carmocca added this to the v1.3.x milestone Jun 18, 2021
@carmocca carmocca changed the title [WIP] Actually show deprecation warnings and their line level [2/2] Actually show deprecation warnings and their line level [2/2] Jun 18, 2021
@carmocca carmocca marked this pull request as ready for review June 18, 2021 13:47
awaelchli
awaelchli reviewed Jun 21, 2021
View reviewed changes
awaelchli
awaelchli approved these changes Jun 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not fully convinced about splitting up the the rank_zero functions but if circular imports are trouble, ok sounds fair :)

carmocca
carmocca commented Jun 21, 2021
View reviewed changes
carmocca
carmocca commented Jun 21, 2021
View reviewed changes
@carmocca carmocca added the ready to be merged PRs ready to be merged label Jun 21, 2021
Borda
Borda approved these changes Jun 21, 2021
View reviewed changes
tchaton
tchaton approved these changes Jun 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@carmocca carmocca merged commit dd340a6 into master Jun 21, 2021
@carmocca carmocca deleted the bugfix/fix-deprecation-warnings branch June 21, 2021 16:51
awaelchli added a commit that referenced this pull request Jun 22, 2021
@awaelchli
Actually show deprecation warnings and their line level [2/2] (#8002)
238c1a2 
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
lexierule pushed a commit that referenced this pull request Jun 22, 2021
@awaelchli @lexierule
Actually show deprecation warnings and their line level [2/2] (#8002)
55271b1 
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
@yifuwang yifuwang mentioned this pull request Jun 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@tchaton tchaton tchaton approved these changes

@ananthsub ananthsub Awaiting requested review from ananthsub

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

+1 more reviewer

@awaelchli awaelchli awaelchli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carmocca carmocca

Labels

bug Something isn't working priority: 0 High priority task ready to be merged PRs ready to be merged

Projects

None yet

Milestone

pl:1.3.x

Development

Successfully merging this pull request may close these issues.

4 participants

@carmocca @awaelchli @Borda @tchaton