fix trainer not resetting lightning_optimizers#6372
Merged
Conversation
|
Hello @awaelchli! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-03-06 17:27:02 UTC |
3dfe832 to
440db6a
Compare
Codecov Report
@@ Coverage Diff @@
## master #6372 +/- ##
=======================================
- Coverage 93% 92% -2%
=======================================
Files 161 161
Lines 11464 11476 +12
=======================================
- Hits 10706 10513 -193
- Misses 758 963 +205 |
rohitgr7
approved these changes
Mar 6, 2021
carmocca
reviewed
Mar 6, 2021
carmocca
approved these changes
Mar 6, 2021
s-rog
approved these changes
Mar 8, 2021
Closed
tchaton
pushed a commit
that referenced
this pull request
Mar 9, 2021
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Borda
pushed a commit
that referenced
this pull request
Mar 9, 2021
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
tchaton
pushed a commit
that referenced
this pull request
Mar 9, 2021
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
lexierule
pushed a commit
that referenced
this pull request
Mar 9, 2021
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
This was referenced Mar 12, 2021
Closed
Closed
[tune](deps): Bump pytorch-lightning from 1.0.3 to 1.2.3 in /python/requirements
sumanthratna/ray#12
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When calling
Trainer.fitmultiple times there is a bug where in the second fit the optimization would use thelightning optimizers from the first model because it is still hanging on to the old list.
The fix is to reset the list when new optimizers are requested from the model.
This way the lightning optimizers get re-wrapped when the training loop starts.
Fixes #6285
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃