fix argparse conflicting options error#5569
Merged
Borda merged 2 commits intoLightning-AI:masterfrom Jan 19, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5569 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 135 135
Lines 10005 10005
======================================
- Hits 9339 9332 -7
- Misses 666 673 +7 |
tchaton
approved these changes
Jan 19, 2021
carmocca
approved these changes
Jan 19, 2021
Borda
approved these changes
Jan 19, 2021
justusschock
approved these changes
Jan 19, 2021
jeffydc
approved these changes
Jan 19, 2021
awaelchli
approved these changes
Jan 19, 2021
Borda
added a commit
that referenced
this pull request
Feb 4, 2021
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sets
add_help=Falsein theparent_parserof semantic_segmentation in pl_examples. A conflicting options error occurs when running through command line becauseadd_help=Truein both the parent parser and the parser adding model specific args. Either one of them can be set toFalseto fix the error and still display the help optionsFixes #5568
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃