Skip to content

Fix val_check_interval with fast_dev_run#5540

Merged
tchaton merged 2 commits intomasterfrom
bugfix/fdr_val_check
Jan 18, 2021
Merged

Fix val_check_interval with fast_dev_run#5540
tchaton merged 2 commits intomasterfrom
bugfix/fdr_val_check

Conversation

@rohitgr7
Copy link
Copy Markdown
Contributor

@rohitgr7 rohitgr7 commented Jan 16, 2021 •
edited
Loading

What does this PR do?

Fixes #5538

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@rohitgr7 rohitgr7 added the bug Something isn't working label Jan 16, 2021
@rohitgr7 rohitgr7 added this to the 1.1.x milestone Jan 16, 2021
@rohitgr7 rohitgr7 marked this pull request as ready for review January 16, 2021 12:29
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 16, 2021

Codecov Report

Merging #5540 (ad7f14b) into master (6926b84) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #5540   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         135     135           
  Lines       10007   10007           
======================================
- Hits         9341    9334    -7     
- Misses        666     673    +7

awaelchli
awaelchli reviewed Jan 16, 2021
View reviewed changes
@Borda Borda added the priority: 0 High priority task label Jan 17, 2021
@Borda Borda enabled auto-merge (squash) January 17, 2021 21:44
Borda
Borda approved these changes Jan 17, 2021
View reviewed changes
@tchaton tchaton disabled auto-merge January 18, 2021 08:24
@tchaton tchaton merged commit c80e45d into master Jan 18, 2021
@tchaton tchaton deleted the bugfix/fdr_val_check branch January 18, 2021 08:24
Borda pushed a commit that referenced this pull request Feb 4, 2021
@rohitgr7 @Borda
Fix val_check_interval with fast_dev_run (#5540)
8f9ceb9 
* fix val_check_interval with fast_dev_run

* chlog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@tchaton tchaton tchaton approved these changes

@justusschock justusschock justusschock approved these changes

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

+1 more reviewer

@awaelchli awaelchli awaelchli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working priority: 0 High priority task

Projects

None yet

Milestone

pl:1.1.x

Development

Successfully merging this pull request may close these issues.

fast_dev_run breaks with val_check_interval

5 participants

@rohitgr7 @awaelchli @Borda @tchaton @justusschock