Skip to content

[bugfix] Fix signature mismatch in DDPCPUHPCAccelerator's model_to_device#5505

Merged
SeanNaren merged 2 commits intoLightning-AI:masterfrom
ananthsub:ddp-hpc-cpu-fix
Jan 16, 2021
Merged

[bugfix] Fix signature mismatch in DDPCPUHPCAccelerator's model_to_device#5505
SeanNaren merged 2 commits intoLightning-AI:masterfrom
ananthsub:ddp-hpc-cpu-fix

Conversation

@ananthsub
Copy link
Copy Markdown
Contributor

@ananthsub ananthsub commented Jan 13, 2021 •
edited
Loading

What does this PR do?

model_to_device in the parent class does not take process_idx as an argument anymore. however, the child class here wasn't updated, leading to this signature mismatch. as a result, folks using the torchelastic+ddp+cpu will run into a crash in ddp_train complaining about the the process_idx argument missing

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@ananthsub
Copy link
Copy Markdown
Contributor Author

ananthsub commented Jan 13, 2021

this along with #5157 points to an opportunity for us to improve the multi-gpu/cpu CI to catch these proactively. @tchaton @Borda what do you think we could set up for these use cases?

@awaelchli awaelchli linked an issue Jan 13, 2021 that may be closed by this pull request
model_to_device() missing 1 required positional argument 'process_idx' #5465
Closed
@awaelchli awaelchli added bug Something isn't working distributed Generic distributed-related topic labels Jan 13, 2021
@awaelchli awaelchli added this to the 1.1.x milestone Jan 13, 2021
@ananthsub ananthsub requested a review from Borda as a code owner January 13, 2021 21:12
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 13, 2021 •
edited
Loading

Codecov Report

Merging #5505 (fb0c300) into master (7f352cb) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5505   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         135     135           
  Lines       10007   10007           
======================================
  Hits         9341    9341           
  Misses        666     666

@SeanNaren SeanNaren merged commit 6926b84 into Lightning-AI:master Jan 16, 2021
Borda pushed a commit that referenced this pull request Feb 4, 2021
@ananthsub @Borda
[bugfix] Fix signature mismatch in DDPCPUHPCAccelerator's model_to_de…
cd11fee 
…vice (#5505)

* Update ddp_cpu_hpc_accelerator.py

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justusschock justusschock justusschock approved these changes

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@Borda Borda Awaiting requested review from Borda

+2 more reviewers

@awaelchli awaelchli awaelchli approved these changes

@s-rog s-rog s-rog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working distributed Generic distributed-related topic

Projects

None yet

Milestone

pl:1.1.x

Development

Successfully merging this pull request may close these issues.

model_to_device() missing 1 required positional argument 'process_idx'

5 participants

@ananthsub @awaelchli @justusschock @s-rog @SeanNaren