Skip to content

Fix Wrong exception message#5492

Merged
Borda merged 3 commits intoLightning-AI:masterfrom
lacrosse91:master
Jan 14, 2021
Merged

Fix Wrong exception message#5492
Borda merged 3 commits intoLightning-AI:masterfrom
lacrosse91:master

Conversation

@lacrosse91
Copy link
Copy Markdown
Contributor

@lacrosse91 lacrosse91 commented Jan 13, 2021 •
edited by carmocca
Loading

What does this PR do?

Fixes #5490 <- this links related issue to this PR

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 13, 2021 •
edited
Loading

Codecov Report

Merging #5492 (dc56043) into master (24fb75a) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5492   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         135     135           
  Lines       10006   10006           
======================================
  Hits         9329    9329           
  Misses        677     677

rohitgr7
rohitgr7 reviewed Jan 13, 2021
View reviewed changes
@Borda @rohitgr7
Apply suggestions from code review
4ef3d48 
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
@Borda Borda enabled auto-merge (squash) January 13, 2021 12:00
@lacrosse91 lacrosse91 requested a review from tchaton January 14, 2021 00:17
@rohitgr7 rohitgr7 added ready to be merged PRs ready to be merged docs Documentation related labels Jan 14, 2021
@rohitgr7 rohitgr7 added this to the 1.1.x milestone Jan 14, 2021
@Borda Borda merged commit d15f7a0 into Lightning-AI:master Jan 14, 2021
Borda added a commit that referenced this pull request Feb 4, 2021
@lacrosse91 @Borda @rohitgr7
Fix Wrong exception message (#5492)
c9a7f17 
* Update accelerator_connector.py

* Apply suggestions from code review

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

+3 more reviewers

@awaelchli awaelchli awaelchli approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@jeffydc jeffydc jeffydc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation related ready to be merged PRs ready to be merged

Projects

None yet

Milestone

pl:1.1.x

Development

Successfully merging this pull request may close these issues.

Wrong exception message

7 participants

@lacrosse91 @awaelchli @tchaton @SkafteNicki @rohitgr7 @jeffydc @Borda