Skip to content

Prepare 1.1.4 Release#5482

Merged
SeanNaren merged 2 commits intomasterfrom
1.1.4-release
Jan 12, 2021
Merged

Prepare 1.1.4 Release#5482
SeanNaren merged 2 commits intomasterfrom
1.1.4-release

Conversation

@SeanNaren
Copy link
Copy Markdown
Contributor

@SeanNaren SeanNaren commented Jan 12, 2021 •
edited
Loading

What does this PR do?

Updates changelog and increment release version.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren requested a review from awaelchli as a code owner January 12, 2021 12:23
@SeanNaren SeanNaren self-assigned this Jan 12, 2021
@SeanNaren SeanNaren added this to the 1.1.x milestone Jan 12, 2021
@Borda Borda added the docs Documentation related label Jan 12, 2021
@Borda Borda enabled auto-merge (squash) January 12, 2021 12:29
@Borda Borda added the ready to be merged PRs ready to be merged label Jan 12, 2021
Merge branch 'master' into 1.1.4-release
4c0f25d 
# Conflicts:
#	pytorch_lightning/__init__.py
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 12, 2021

Codecov Report

Merging #5482 (4c0f25d) into master (c00d570) will increase coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #5482    +/-   ##
=======================================
+ Coverage      89%     93%    +4%     
=======================================
  Files         135     135            
  Lines       10015   10015            
=======================================
+ Hits         8953    9338   +385     
+ Misses       1062     677   -385

@SeanNaren SeanNaren requested a review from carmocca January 12, 2021 18:02
@SeanNaren SeanNaren disabled auto-merge January 12, 2021 18:53
@SeanNaren SeanNaren merged commit 652df18 into master Jan 12, 2021
@SeanNaren SeanNaren deleted the 1.1.4-release branch January 12, 2021 18:53
SeanNaren added a commit that referenced this pull request Jan 13, 2021
@SeanNaren
Increment version, update CHANGELOG.md (#5482)
83d9cf3 
(cherry picked from commit 652df18)
SeanNaren added a commit that referenced this pull request Jan 13, 2021
@SeanNaren
Increment version, update CHANGELOG.md (#5482)
5397e1c 
(cherry picked from commit 652df18)
SeanNaren added a commit that referenced this pull request Jan 19, 2021
@SeanNaren
Increment version, update CHANGELOG.md (#5482)
e286736 
(cherry picked from commit 652df18)
Borda pushed a commit that referenced this pull request Jan 23, 2021
@SeanNaren @Borda
update CHANGELOG.md (#5482)
882c51e 
(cherry picked from commit 652df18)
Borda pushed a commit that referenced this pull request Jan 25, 2021
@SeanNaren @Borda
update CHANGELOG.md (#5482)
2afaecc 
(cherry picked from commit 652df18)
Borda pushed a commit that referenced this pull request Jan 26, 2021
@SeanNaren @Borda
update CHANGELOG.md (#5482)
0c2a4c7 
(cherry picked from commit 652df18)
Borda pushed a commit that referenced this pull request Jan 26, 2021
@SeanNaren @Borda
update CHANGELOG.md (#5482)
5a4a4a4 
(cherry picked from commit 652df18)
Borda pushed a commit that referenced this pull request Jan 26, 2021
@SeanNaren @Borda
update CHANGELOG.md (#5482)
942488b 
(cherry picked from commit 652df18)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

+1 more reviewer

@carmocca carmocca carmocca approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@SeanNaren SeanNaren

Labels

docs Documentation related has conflicts ready to be merged PRs ready to be merged

Projects

None yet

Milestone

pl:1.1.x

Development

Successfully merging this pull request may close these issues.

4 participants

@SeanNaren @Borda @carmocca @SkafteNicki