populate some more legacy checkpoints by Borda · Pull Request #5457 · Lightning-AI/pytorch-lightning

Borda · 2021-01-11T08:47:10Z

What does this PR do?

adding some more legacy checkpoints, followup on #5223

Before submitting

Was this discussed/approved via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified
Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

tests/checkpointing/test_legacy_checkpoints.py

codecov · 2021-01-11T10:16:18Z

Codecov Report

Merging #5457 (0f5d2ca) into master (499d503) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5457   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         135     135           
  Lines       10011   10011           
======================================
- Hits         9324    9317    -7     
- Misses        687     694    +7

Borda · 2021-01-11T10:49:52Z

well not sure why the newly added ckpt fails, locally it works fine...

tests/checkpointing/test_legacy_checkpoints.py

Borda · 2021-01-11T12:03:59Z

seems that there is a problem with PT, as the same files can be loaded in 1.5 1.6 1.7 but not in 1.4
and it includes also the later PL versions such as 1.1.3

FAILED tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[0.8.3]
FAILED tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[0.8.4]
FAILED tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[0.8.5]
FAILED tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[0.9.0]
FAILED tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[1.0.8]
FAILED tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[1.1.0]
FAILED tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[1.1.1]
FAILED tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[1.1.2]
FAILED tests/checkpointing/test_legacy_checkpoints.py::test_resume_legacy_checkpoints[1.1.3]

legacy/zero_training.py

carmocca · 2021-01-11T12:30:32Z

seems that there is a problem with PT, as the same files can be loaded in 1.5 1.6 1.7 but not in 1.4
and it includes also the later PL versions such as 1.1.3

what's the error?

Borda · 2021-01-11T14:36:58Z

seems that there is a problem with PT, as the same files can be loaded in 1.5 1.6 1.7 but not in 1.4 and it includes also the later PL versions such as 1.1.3

what's the error?

PT somehow states that the ckpt is an archive...

      if _is_zipfile(f):
          # .zip is used for torch.jit.save and will throw an un-pickling error here
>         raise RuntimeError("{} is a zip archive (did you mean to use torch.jit.load()?)".format(f.name))
E         RuntimeError: /home/runner/work/pytorch-lightning/pytorch-lightning/legacy/checkpoints/1.1.3/epoch=4-step=319.ckpt is a zip archive (did you mean to use torch.jit.load()?)

Borda · 2021-01-11T18:59:46Z

this seems to be very similart issue:

torch.load issue on loading file created by torch.save pytorch/pytorch#25214

so the problem is that we cannot save checkpoints with and load with lover version, the breaking change is in 1.7 so for creating legacy checkpoints we have to use the lowest supported version...

…chLightning/pytorch-lightning into tests/populate-legacy-ckpt

Borda · 2021-01-11T20:26:32Z

ok, seems that there is some problem with v0.8.5 and v0.9.0 so I would leave it for another PR...
eventually, we may consider making some workaround to transform archive to loadable format or use torch.jit

* populate some more legacy checkpoints * . * pt freeze * . * skip Co-authored-by: chaton <thomas@grid.ai> (cherry picked from commit f065ea6)

populate some more legacy checkpoints

ff406d0

Borda added feature Is an improvement or enhancement ci Continuous Integration labels Jan 11, 2021

Borda added this to the 1.1.x milestone Jan 11, 2021

.

84ebbcb

Borda marked this pull request as ready for review January 11, 2021 09:18

Borda requested review from SeanNaren, awaelchli, justusschock, tchaton and williamFalcon as code owners January 11, 2021 09:18

Borda requested review from SkafteNicki, ananyahjha93, carmocca, lezwon, rohitgr7, s-rog, teddykoker, tullie and yukw777 January 11, 2021 09:18

Borda self-assigned this Jan 11, 2021

Borda added the priority: 1 Medium priority task label Jan 11, 2021

justusschock approved these changes Jan 11, 2021

View reviewed changes

tests/checkpointing/test_legacy_checkpoints.py Show resolved Hide resolved

SkafteNicki approved these changes Jan 11, 2021

View reviewed changes

tchaton approved these changes Jan 11, 2021

View reviewed changes

tests/checkpointing/test_legacy_checkpoints.py Outdated Show resolved Hide resolved

Merge branch 'master' into tests/populate-legacy-ckpt

0f5d2ca

Borda changed the title ~~populate some more legacy checkpoints~~ populate some more legacy checkpoints [wip] Jan 11, 2021

carmocca reviewed Jan 11, 2021

View reviewed changes

legacy/zero_training.py Outdated Show resolved Hide resolved

pt freeze

3bf5b94

.

26ab67c

Borda changed the title ~~populate some more legacy checkpoints [wip]~~ populate some more legacy checkpoints Jan 11, 2021

Merge branch 'master' into tests/populate-legacy-ckpt

ecd6b8e

Borda requested a review from carmocca January 11, 2021 19:40

Borda added the ready to be merged PRs ready to be merged label Jan 11, 2021

Borda added 2 commits January 11, 2021 21:22

skip

740cc47

Merge branch 'tests/populate-legacy-ckpt' of https://github.com/PyTor…

ed4305f

…chLightning/pytorch-lightning into tests/populate-legacy-ckpt

Borda enabled auto-merge (squash) January 11, 2021 20:27

Borda disabled auto-merge January 11, 2021 20:38

pep8

32747b4

Borda enabled auto-merge (squash) January 11, 2021 20:44

Borda merged commit f065ea6 into master Jan 12, 2021

Borda deleted the tests/populate-legacy-ckpt branch January 12, 2021 01:36

SeanNaren pushed a commit that referenced this pull request Jan 12, 2021

populate some more legacy checkpoints (#5457)

640b5aa

* populate some more legacy checkpoints * . * pt freeze * . * skip Co-authored-by: chaton <thomas@grid.ai> (cherry picked from commit f065ea6)

SeanNaren pushed a commit that referenced this pull request Jan 12, 2021

populate some more legacy checkpoints (#5457)

2e7fa7e

* populate some more legacy checkpoints * . * pt freeze * . * skip Co-authored-by: chaton <thomas@grid.ai> (cherry picked from commit f065ea6)

SeanNaren pushed a commit that referenced this pull request Jan 13, 2021

populate some more legacy checkpoints (#5457)

373fa2b

* populate some more legacy checkpoints * . * pt freeze * . * skip Co-authored-by: chaton <thomas@grid.ai> (cherry picked from commit f065ea6)

SeanNaren pushed a commit that referenced this pull request Jan 13, 2021

populate some more legacy checkpoints (#5457)

2376112

* populate some more legacy checkpoints * . * pt freeze * . * skip Co-authored-by: chaton <thomas@grid.ai> (cherry picked from commit f065ea6)

SeanNaren pushed a commit that referenced this pull request Jan 19, 2021

populate some more legacy checkpoints (#5457)

7c081c7

* populate some more legacy checkpoints * . * pt freeze * . * skip Co-authored-by: chaton <thomas@grid.ai> (cherry picked from commit f065ea6)

Borda added a commit that referenced this pull request Jan 23, 2021

populate some more legacy checkpoints (#5457)

65233f6

* populate some more legacy checkpoints * . * pt freeze * . * skip Co-authored-by: chaton <thomas@grid.ai> (cherry picked from commit f065ea6)

Borda added a commit that referenced this pull request Jan 25, 2021

populate some more legacy checkpoints (#5457)

fc58f66

* populate some more legacy checkpoints * . * pt freeze * . * skip Co-authored-by: chaton <thomas@grid.ai> (cherry picked from commit f065ea6)

Borda added a commit that referenced this pull request Jan 26, 2021

populate some more legacy checkpoints (#5457)

8262c19

* populate some more legacy checkpoints * . * pt freeze * . * skip Co-authored-by: chaton <thomas@grid.ai> (cherry picked from commit f065ea6)

Borda added a commit that referenced this pull request Jan 26, 2021

populate some more legacy checkpoints (#5457)

bd71b6a

* populate some more legacy checkpoints * . * pt freeze * . * skip Co-authored-by: chaton <thomas@grid.ai> (cherry picked from commit f065ea6)

Borda added a commit that referenced this pull request Jan 26, 2021

populate some more legacy checkpoints (#5457)

ee934de

* populate some more legacy checkpoints * . * pt freeze * . * skip Co-authored-by: chaton <thomas@grid.ai> (cherry picked from commit f065ea6)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

populate some more legacy checkpoints#5457

populate some more legacy checkpoints#5457
Borda merged 9 commits intomasterfrom
tests/populate-legacy-ckpt

Borda commented Jan 11, 2021 •

edited

Loading

Uh oh!

Uh oh!

codecov bot commented Jan 11, 2021 •

edited

Loading

Uh oh!

Borda commented Jan 11, 2021

Uh oh!

Uh oh!

Borda commented Jan 11, 2021

Uh oh!

Uh oh!

carmocca commented Jan 11, 2021

Uh oh!

Borda commented Jan 11, 2021 •

edited

Loading

Uh oh!

Borda commented Jan 11, 2021

Uh oh!

Borda commented Jan 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Borda commented Jan 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Before submitting

PR review

Did you have fun?

Uh oh!

Uh oh!

codecov bot commented Jan 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Borda commented Jan 11, 2021

Uh oh!

Uh oh!

Borda commented Jan 11, 2021

Uh oh!

Uh oh!

carmocca commented Jan 11, 2021

Uh oh!

Borda commented Jan 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Borda commented Jan 11, 2021

Uh oh!

Borda commented Jan 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Borda commented Jan 11, 2021 •

edited

Loading

codecov bot commented Jan 11, 2021 •

edited

Loading

Borda commented Jan 11, 2021 •

edited

Loading