Skip to content

GH action - auto-update PRs#5451

Merged
Borda merged 6 commits intomasterfrom
ci/auto-update
Jan 11, 2021
Merged

GH action - auto-update PRs#5451
Borda merged 6 commits intomasterfrom
ci/auto-update

Conversation

@Borda
Copy link
Copy Markdown
Collaborator

@Borda Borda commented Jan 10, 2021 •
edited
Loading

What does this PR do?

This shall update PR which is ready-to-go but need to be tested in action as not sure how it will act if there are some collisions, and if it works we can also drop a comment message
see: https://github.com/marketplace/actions/auto-update

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added feature Is an improvement or enhancement productivity labels Jan 10, 2021
@Borda Borda added this to the 1.1.x milestone Jan 10, 2021
@Borda Borda requested a review from tchaton as a code owner January 10, 2021 19:44
@Borda Borda self-assigned this Jan 10, 2021
SeanNaren
SeanNaren approved these changes Jan 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@SeanNaren SeanNaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice this is awesome. Hopefully works out!

@Borda Borda added the ready to be merged PRs ready to be merged label Jan 10, 2021
@Borda Borda enabled auto-merge (squash) January 10, 2021 20:00
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 10, 2021 •
edited
Loading

Codecov Report

Merging #5451 (1303122) into master (499d503) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5451   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         135     135           
  Lines       10011   10011           
======================================
  Hits         9324    9324           
  Misses        687     687

@awaelchli
Copy link
Copy Markdown
Contributor

awaelchli commented Jan 10, 2021

"update" branch means it will trigger CI too? that would be very costly considering drone takes almost 20 mins per run

@Borda
Copy link
Copy Markdown
Collaborator Author

Borda commented Jan 10, 2021

"update" branch means it will trigger CI too? that would be very costly considering drone takes almost 20 mins per run

it will work only with ready-to-go label, as @SeanNaren asked for :]

s-rog
s-rog approved these changes Jan 11, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@s-rog s-rog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know this existed!

tchaton
tchaton approved these changes Jan 11, 2021
View reviewed changes
@Borda Borda merged commit 92bbf2f into master Jan 11, 2021
@Borda Borda deleted the ci/auto-update branch January 11, 2021 12:32
This was referenced Jan 12, 2021
Closed
Closed
SeanNaren pushed a commit that referenced this pull request Jan 12, 2021
@Borda
GH action - auto-update PRs (#5451)
6b5b7b4 
* GH action - auto-update PRs

* .

(cherry picked from commit 92bbf2f)
SeanNaren pushed a commit that referenced this pull request Jan 12, 2021
@Borda
GH action - auto-update PRs (#5451)
b5e0a86 
* GH action - auto-update PRs

* .

(cherry picked from commit 92bbf2f)
SeanNaren pushed a commit that referenced this pull request Jan 13, 2021
@Borda
GH action - auto-update PRs (#5451)
5be4ad4 
* GH action - auto-update PRs

* .

(cherry picked from commit 92bbf2f)
@Borda Borda mentioned this pull request Jan 13, 2021
Merged
12 tasks
SeanNaren pushed a commit that referenced this pull request Jan 13, 2021
@Borda
GH action - auto-update PRs (#5451)
9cae5d8 
* GH action - auto-update PRs

* .

(cherry picked from commit 92bbf2f)
SeanNaren pushed a commit that referenced this pull request Jan 19, 2021
@Borda
GH action - auto-update PRs (#5451)
3d99127 
* GH action - auto-update PRs

* .

(cherry picked from commit 92bbf2f)
Borda added a commit that referenced this pull request Jan 23, 2021
@Borda
GH action - auto-update PRs (#5451)
d5008b2 
* GH action - auto-update PRs

* .

(cherry picked from commit 92bbf2f)
Borda added a commit that referenced this pull request Jan 25, 2021
@Borda
GH action - auto-update PRs (#5451)
eb4f7be 
* GH action - auto-update PRs

* .

(cherry picked from commit 92bbf2f)
Borda added a commit that referenced this pull request Jan 26, 2021
@Borda
GH action - auto-update PRs (#5451)
3782a06 
* GH action - auto-update PRs

* .

(cherry picked from commit 92bbf2f)
Borda added a commit that referenced this pull request Jan 26, 2021
@Borda
GH action - auto-update PRs (#5451)
a8a4954 
* GH action - auto-update PRs

* .

(cherry picked from commit 92bbf2f)
Borda added a commit that referenced this pull request Jan 26, 2021
@Borda
GH action - auto-update PRs (#5451)
fd49795 
* GH action - auto-update PRs

* .

(cherry picked from commit 92bbf2f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaton tchaton tchaton approved these changes

@justusschock justusschock justusschock approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@yukw777 yukw777 Awaiting requested review from yukw777

+4 more reviewers

@awaelchli awaelchli awaelchli approved these changes

@SeanNaren SeanNaren SeanNaren approved these changes

@carmocca carmocca carmocca approved these changes

@s-rog s-rog s-rog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Borda Borda

Labels

feature Is an improvement or enhancement ready to be merged PRs ready to be merged

Projects

None yet

Milestone

pl:1.1.x

Development

Successfully merging this pull request may close these issues.

8 participants

@Borda @awaelchli @SeanNaren @carmocca @tchaton @justusschock @SkafteNicki @s-rog