simplify training phase as Enum#5419
Merged
Borda merged 17 commits intorelease/1.2-devfrom Jan 13, 2021
Merged
Conversation
12 tasks
carmocca
reviewed
Jan 9, 2021
carmocca
reviewed
Jan 9, 2021
carmocca
reviewed
Jan 9, 2021
Contributor
|
Can we unify this with LoggerStages? |
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #5419 +/- ##
===============================================
Coverage 93% 93%
===============================================
Files 151 151
Lines 10617 10641 +24
===============================================
+ Hits 9835 9858 +23
- Misses 782 783 +1 |
carmocca
reviewed
Jan 10, 2021
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
carmocca
approved these changes
Jan 10, 2021
SkafteNicki
approved these changes
Jan 10, 2021
s-rog
approved these changes
Jan 11, 2021
tchaton
reviewed
Jan 11, 2021
Contributor
tchaton
left a comment
There was a problem hiding this comment.
Great addition ! Let's use this to refactor LoggerConnector internal Stage.
Also, we should provided context manager or stage stack as we can run evaluation in training.
justusschock
approved these changes
Jan 11, 2021
Collaborator
Author
yes, that is my goal, but as it is widely requested we shall do these changes in smaller steps :] |
Collaborator
Author
|
@tchaton mind recheck... |
tchaton
approved these changes
Jan 11, 2021
awaelchli
reviewed
Jan 11, 2021
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
3 tasks
Borda
added a commit
that referenced
this pull request
Jan 13, 2021
* simplify training phase as Enum * tests * . * . * rename * Apply suggestions from code review Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> * Apply suggestions from code review Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> * rename * flake8 Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
simplify the training phase logic
application in code will follow
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃