Skip to content

Update notes on ddp_spawn accelerator in multi-gpu docs#5402

Merged
awaelchli merged 8 commits intomasterfrom
docs/spawn_typo
Jan 13, 2021
Merged

Update notes on ddp_spawn accelerator in multi-gpu docs#5402
awaelchli merged 8 commits intomasterfrom
docs/spawn_typo

Conversation

@awaelchli
Copy link
Copy Markdown
Contributor

@awaelchli awaelchli commented Jan 7, 2021 •
edited
Loading

What does this PR do?

Fixes #5358

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added the docs Documentation related label Jan 7, 2021
@awaelchli awaelchli added this to the 1.1.x milestone Jan 7, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 7, 2021 •
edited
Loading

Codecov Report

Merging #5402 (899f75f) into master (a9377e3) will decrease coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #5402    +/-   ##
=======================================
- Coverage      93%     93%    -0%     
=======================================
  Files         135     135            
  Lines       10015    9875   -140     
=======================================
- Hits         9338    9185   -153     
- Misses        677     690    +13

@awaelchli awaelchli added the ready to be merged PRs ready to be merged label Jan 11, 2021
@awaelchli awaelchli enabled auto-merge (squash) January 13, 2021 10:38
@awaelchli awaelchli merged commit 36198ec into master Jan 13, 2021
@awaelchli awaelchli deleted the docs/spawn_typo branch January 13, 2021 12:53
Borda pushed a commit that referenced this pull request Feb 4, 2021
@awaelchli @github-actions @Borda
fix typo in multi-gpu docs (#5402)
96769f2 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@justusschock justusschock justusschock approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@edenlightning edenlightning Awaiting requested review from edenlightning

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

Assignees

No one assigned

Labels

docs Documentation related ready to be merged PRs ready to be merged

Projects

None yet

Milestone

pl:1.1.x

Development

Successfully merging this pull request may close these issues.

'RuntimeError: No rendezvous handler for env://' with multi-gpu

4 participants

@awaelchli @Borda @justusschock @SkafteNicki