Skip to content

[Docs] fix on_after_backward example#5278

Merged
Borda merged 6 commits intomasterfrom
docs/oab
Jan 12, 2021
Merged

[Docs] fix on_after_backward example#5278
Borda merged 6 commits intomasterfrom
docs/oab

Conversation

@rohitgr7
Copy link
Copy Markdown
Contributor

@rohitgr7 rohitgr7 commented Dec 27, 2020 •
edited
Loading

What does this PR do?

Fixes #5238

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes [if needed]?
  • Did you write any new necessary tests [no need for typos, docs]?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone are aligned!

Did you have fun?

Make sure you had fun coding 🙃

@rohitgr7 rohitgr7 added the docs Documentation related label Dec 27, 2020
@rohitgr7 rohitgr7 added this to the 1.1.x milestone Dec 27, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 27, 2020 •
edited
Loading

Codecov Report

Merging #5278 (4b3f146) into master (1ec1d3e) will decrease coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #5278    +/-   ##
=======================================
- Coverage      93%     93%    -0%     
=======================================
  Files         135     135            
  Lines       10015    9875   -140     
=======================================
- Hits         9338    9185   -153     
- Misses        677     690    +13

@rohitgr7 rohitgr7 marked this pull request as ready for review December 28, 2020 06:55
@Borda
Copy link
Copy Markdown
Collaborator

Borda commented Dec 28, 2020

@rohitgr7 it seems it does only formating, do not touches any docs...

@rohitgr7
Copy link
Copy Markdown
Contributor Author

rohitgr7 commented Dec 28, 2020

@Borda it was grads = v before which is wrong, changed it to grads = v.grad.

@Borda Borda added the ready to be merged PRs ready to be merged label Dec 31, 2020
@Borda Borda enabled auto-merge (squash) December 31, 2020 08:09
@rohitgr7
Copy link
Copy Markdown
Contributor Author

rohitgr7 commented Jan 4, 2021

@williamFalcon mind review

@Borda Borda merged commit a9377e3 into master Jan 12, 2021
@Borda Borda deleted the docs/oab branch January 12, 2021 23:36
Borda pushed a commit that referenced this pull request Feb 4, 2021
@rohitgr7 @Borda
[Docs] fix on_after_backward example (#5278)
81757ed 
* fix on_after_backward docs

* doc fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@williamFalcon williamFalcon williamFalcon approved these changes

@Borda Borda Borda approved these changes

@tchaton tchaton tchaton approved these changes

@justusschock justusschock justusschock approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

+1 more reviewer

@jeffydc jeffydc jeffydc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation related ready to be merged PRs ready to be merged

Projects

None yet

Milestone

pl:1.1.x

Development

Successfully merging this pull request may close these issues.

How to get average of absolute gradient during the training

7 participants

@rohitgr7 @Borda @williamFalcon @tchaton @justusschock @SkafteNicki @jeffydc