Add automatic optimization property setter to lightning module#5169
Merged
tchaton merged 3 commits intoLightning-AI:masterfrom Jan 11, 2021
Merged
Add automatic optimization property setter to lightning module#5169tchaton merged 3 commits intoLightning-AI:masterfrom
tchaton merged 3 commits intoLightning-AI:masterfrom
Conversation
11 tasks
rohitgr7
reviewed
Dec 18, 2020
Contributor
rohitgr7
left a comment
There was a problem hiding this comment.
this looks better to me. Mind update other tests too?
awaelchli
approved these changes
Dec 18, 2020
Contributor
awaelchli
left a comment
There was a problem hiding this comment.
I thought it already was like this 😄
SkafteNicki
approved these changes
Dec 18, 2020
SeanNaren
approved these changes
Dec 18, 2020
Contributor
Author
will do! |
tchaton
approved these changes
Jan 11, 2021
justusschock
approved these changes
Jan 11, 2021
Codecov Report
@@ Coverage Diff @@
## master #5169 +/- ##
======================================
Coverage 93% 93%
======================================
Files 135 135
Lines 10011 10015 +4
======================================
+ Hits 9324 9328 +4
Misses 687 687 |
12 tasks
SeanNaren
pushed a commit
that referenced
this pull request
Jan 12, 2021
* add automatic optimization property setter to lightning module * Update test_manual_optimization.py Co-authored-by: chaton <thomas@grid.ai> (cherry picked from commit 8748293)
SeanNaren
pushed a commit
that referenced
this pull request
Jan 12, 2021
* add automatic optimization property setter to lightning module * Update test_manual_optimization.py Co-authored-by: chaton <thomas@grid.ai> (cherry picked from commit 8748293)
SeanNaren
pushed a commit
that referenced
this pull request
Jan 13, 2021
* add automatic optimization property setter to lightning module * Update test_manual_optimization.py Co-authored-by: chaton <thomas@grid.ai> (cherry picked from commit 8748293)
SeanNaren
pushed a commit
that referenced
this pull request
Jan 13, 2021
* add automatic optimization property setter to lightning module * Update test_manual_optimization.py Co-authored-by: chaton <thomas@grid.ai> (cherry picked from commit 8748293)
SeanNaren
pushed a commit
that referenced
this pull request
Jan 19, 2021
* add automatic optimization property setter to lightning module * Update test_manual_optimization.py Co-authored-by: chaton <thomas@grid.ai> (cherry picked from commit 8748293)
Borda
pushed a commit
that referenced
this pull request
Jan 23, 2021
* add automatic optimization property setter to lightning module * Update test_manual_optimization.py Co-authored-by: chaton <thomas@grid.ai> (cherry picked from commit 8748293)
Borda
pushed a commit
that referenced
this pull request
Jan 25, 2021
* add automatic optimization property setter to lightning module * Update test_manual_optimization.py Co-authored-by: chaton <thomas@grid.ai> (cherry picked from commit 8748293)
Borda
pushed a commit
that referenced
this pull request
Jan 26, 2021
* add automatic optimization property setter to lightning module * Update test_manual_optimization.py Co-authored-by: chaton <thomas@grid.ai> (cherry picked from commit 8748293)
Borda
pushed a commit
that referenced
this pull request
Jan 26, 2021
* add automatic optimization property setter to lightning module * Update test_manual_optimization.py Co-authored-by: chaton <thomas@grid.ai> (cherry picked from commit 8748293)
Borda
pushed a commit
that referenced
this pull request
Jan 26, 2021
* add automatic optimization property setter to lightning module * Update test_manual_optimization.py Co-authored-by: chaton <thomas@grid.ai> (cherry picked from commit 8748293)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This speeds up the deprecation of the
automatic_optimizationflag from the Trainer by making this property settable on the module. So someone could doself.automatic_optimization = Falsewithout running into an attribute errorFixes # (issue)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃