Skip to content

Warning on eval module#21146

Merged
Borda merged 4 commits intoLightning-AI:masterfrom
SkafteNicki:warning_on_eval_module
Sep 2, 2025
Merged

Warning on eval module#21146
Borda merged 4 commits intoLightning-AI:masterfrom
SkafteNicki:warning_on_eval_module

Conversation

@SkafteNicki
Copy link
Copy Markdown
Collaborator

@SkafteNicki SkafteNicki commented Sep 2, 2025 •
edited by github-actions Bot
Loading

What does this PR do?

Fixes #20986
Fixes #20216
Fixes #20573
Fixes #20177

Adds a simple warning if any module when fit starts are in eval mode. There are cases where you intentionally want modules in eval mode even during fit, however most users want things to be in train mode. This warning should hopefully help users identify this can be a potential problem.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21146.org.readthedocs.build/en/21146/

@SkafteNicki SkafteNicki self-assigned this Sep 2, 2025
@github-actions github-actions Bot added the pl Generic label for PyTorch Lightning package label Sep 2, 2025
deependujha
deependujha approved these changes Sep 2, 2025
View reviewed changes
Comment thread src/lightning/pytorch/loops/fit_loop.py Outdated
@Borda @deependujha
Apply suggestions from code review
5ffe89f 
Co-authored-by: Deependu <deependujha21@gmail.com>
@Borda Borda merged commit 90eba3f into Lightning-AI:master Sep 2, 2025
95 of 97 checks passed
Borda added a commit that referenced this pull request Sep 3, 2025
@SkafteNicki @Borda @deependujha
Warning on eval module (#21146)
581d576 
* add warning
* tests
* changelog
* Apply suggestions from code review

---------

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: Deependu <deependujha21@gmail.com>
(cherry picked from commit 90eba3f)
lantiga pushed a commit that referenced this pull request Sep 5, 2025
@SkafteNicki @Borda
@deependujha @lantiga
Warning on eval module (#21146)
617d03d 
* add warning
* tests
* changelog
* Apply suggestions from code review

---------

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: Deependu <deependujha21@gmail.com>
(cherry picked from commit 90eba3f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@deependujha deependujha deependujha approved these changes

@lantiga lantiga Awaiting requested review from lantiga

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Assignees

@SkafteNicki SkafteNicki

Labels

pl Generic label for PyTorch Lightning package

Projects

None yet

Milestone

No milestone

3 participants

@SkafteNicki @Borda @deependujha