Skip to content

Fix advanced profiler for python >=3.12#20809

Merged
Borda merged 9 commits intoLightning-AI:masterfrom
relativityhd:master
Aug 5, 2025
Merged

Fix advanced profiler for python >=3.12#20809
Borda merged 9 commits intoLightning-AI:masterfrom
relativityhd:master

Conversation

@relativityhd
Copy link
Copy Markdown
Contributor

@relativityhd relativityhd commented May 10, 2025 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #19983

  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20809.org.readthedocs.build/en/20809/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label May 10, 2025
@Borda
Copy link
Copy Markdown
Collaborator

Borda commented May 19, 2025

@relativityhd can we pls add a test for this case

@Borda Borda added the waiting on author Waiting on user action, correction, or update label May 20, 2025
@stale
Copy link
Copy Markdown

stale bot commented Jul 19, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://lightning.ai/docs/pytorch/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Discord. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Jul 19, 2025
@relativityhd
Copy link
Copy Markdown
Contributor Author

relativityhd commented Aug 1, 2025

@Borda Sorry, haven't seen your comment.
To be honest, I don't know how this should be tested properly. There are no tests for it yet, and I don't have the time to create new ones.
Best
Tobias

@stale stale bot removed the won't fix This will not be worked on label Aug 1, 2025
@Borda
Copy link
Copy Markdown
Collaborator

Borda commented Aug 4, 2025

@bhimrazy mind have a look here, pls 🐿️

@bhimrazy
Copy link
Copy Markdown
Collaborator

bhimrazy commented Aug 4, 2025

@bhimrazy mind have a look here, pls 🐿️

Sure @Borda — thanks for the ping! I’ll take a look shortly. 🙌

bhimrazy
bhimrazy approved these changes Aug 4, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@bhimrazy bhimrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I’ll add a minimal test — something simple with nested settings should be fine.

@bhimrazy bhimrazy added profiler and removed waiting on author Waiting on user action, correction, or update labels Aug 4, 2025
@bhimrazy bhimrazy requested a review from Borda August 4, 2025 20:32
deependujha
deependujha reviewed Aug 4, 2025
View reviewed changes
@bhimrazy
Copy link
Copy Markdown
Collaborator

bhimrazy commented Aug 5, 2025

Hi @deependujha, could you pls check if you're able to add the changelog?

- Fixed `AdvancedProfiler` to handle nested profiling actions for Python 3.12+ ([#20809](https://github.com/Lightning-AI/pytorch-lightning/pull/20809))

I started getting a 403 error on my end.

@Borda Borda merged commit 11968ba into Lightning-AI:master Aug 5, 2025
85 checks passed
Borda pushed a commit that referenced this pull request Aug 13, 2025
@relativityhd @pre-commit-ci
@deependujha @bhimrazy @Borda
Fix advanced profiler for python >=3.12 (#20809)
90531b8 
* Fix advanced profiler for python >=3.12
* test: add compatibility test for nested profiling in AdvancedProfiler (Python 3.12+)
* Update src/lightning/pytorch/profilers/advanced.py
* changelog

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Deependu <deependujha21@gmail.com>
Co-authored-by: Bhimraj Yadav <bhimrajyadav977@gmail.com>
(cherry picked from commit 11968ba)
Borda pushed a commit that referenced this pull request Aug 13, 2025
@relativityhd @pre-commit-ci
@deependujha @bhimrazy @Borda
Fix advanced profiler for python >=3.12 (#20809)
5af57a6 
* Fix advanced profiler for python >=3.12
* test: add compatibility test for nested profiling in AdvancedProfiler (Python 3.12+)
* Update src/lightning/pytorch/profilers/advanced.py
* changelog

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Deependu <deependujha21@gmail.com>
Co-authored-by: Bhimraj Yadav <bhimrajyadav977@gmail.com>
(cherry picked from commit 11968ba)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deependujha deependujha deependujha left review comments

@Borda Borda Borda approved these changes

@bhimrazy bhimrazy bhimrazy approved these changes

@lantiga lantiga Awaiting requested review from lantiga

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Assignees

No one assigned

Labels

pl Generic label for PyTorch Lightning package profiler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Another profiling tool is already active

4 participants

@relativityhd @Borda @bhimrazy @deependujha