Allow a custom parser class when using LightningCLI#20596
Merged
Borda merged 4 commits intoLightning-AI:masterfrom Mar 10, 2025
mauvilsa:cli-custom-parser-class
Merged
Allow a custom parser class when using LightningCLI#20596Borda merged 4 commits intoLightning-AI:masterfrom mauvilsa:cli-custom-parser-class
Borda merged 4 commits intoLightning-AI:masterfrom
mauvilsa:cli-custom-parser-class
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20596 +/- ##
=======================================
Coverage 79% 79%
=======================================
Files 264 264
Lines 23316 23317 +1
=======================================
+ Hits 18326 18372 +46
+ Misses 4990 4945 -45 |
Borda
approved these changes
Mar 10, 2025
Borda
pushed a commit
that referenced
this pull request
Mar 12, 2025
* Allow a custom parser class when using LightningCLI * Update changelog (cherry picked from commit 5073ac1)
lexierule
pushed a commit
that referenced
this pull request
Mar 18, 2025
* Allow a custom parser class when using LightningCLI * Update changelog (cherry picked from commit 5073ac1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Recently jsonargparse added new possibilities by customizing the argument parser class, for example:
--flaginstead of--flag true? omni-us/jsonargparse#355However, currently
LightningCLIdoesn't allow changing the parser class to use. This pull request makes that possible.Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20596.org.readthedocs.build/en/20596/