fix(ops-gsd-states): annotate SUBORDINATE projects so YOLO doesn't false-flag them#204
Conversation
…lse-flag them When a project's .planning/STATE.md frontmatter has `status: subordinate_to_workspace`, its tracking is intentionally delegated to a workspace-level coordinator (e.g. healify-api -> healify- workspace, healify-agentcore -> healify-workspace). The C-suite YOLO agents were treating these as independent projects and flagging them as "stalled" when their phase progress was static — but the staticness is correct: the workspace owns the schedule. Add a header annotation `[SUBORDINATE — tracking delegated to workspace; do NOT flag as stalled]` so the C-suite agents have an inline signal to suppress those false fires. Pairs with the CLAIM VERIFICATION GUARDRAIL shipped in 2.1.1 (which already requires checking git log before flagging "broken" — this gives them an even earlier short-circuit). Concrete case from 2026-05-01 YOLO session: COO claimed healify-api v3.1 Phase 1 was "stalled 6d on closed PR #3217". Reality: PR #3217 was intentionally closed and superseded by #3222, which merged 2026-04-25. The healify-workspace symlinked STATE.md correctly reflects this with `status: subordinate_to_workspace`; the YOLO scan would have surfaced that status if the script annotated it. Implementation: small awk frontmatter scalar parser; activates only on the literal value `subordinate_to_workspace`; leaves all other status values silent (no header noise for normal projects). Falls back cleanly if the awk fails or the field is absent (no `set -e` regression).
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 34 minutes and 37 seconds.Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.
Reviewed by Cursor Bugbot for commit 57a449a. Configure here.
| if (idx > 0) { | ||
| f = substr($0, 1, idx - 1) | ||
| v = substr($0, idx + 1) | ||
| sub(/^[[:space:]]+/, "", f); sub(/[[:space:]]+$/, "", f) |
There was a problem hiding this comment.
Whitespace stripping matches nested YAML keys as top-level
Low Severity
The frontmatter_value function is documented as extracting a "top-level YAML frontmatter scalar," but sub(/^[[:space:]]+/, "", f) strips leading whitespace from the field name before comparison. This means indented (nested) YAML keys like status: subordinate_to_workspace under a parent mapping would match identically to a top-level status key. If a nested status key appears before the real top-level one, the wrong value is returned — potentially causing a false SUBORDINATE annotation or, conversely, missing one.
Reviewed by Cursor Bugbot for commit 57a449a. Configure here.
Patch release rolling up the second-pass YOLO false-fire suppression merged tonight (#204): - bin/ops-gsd-states now annotates `[SUBORDINATE — tracking delegated to workspace; do NOT flag as stalled]` for any GSD project whose STATE.md frontmatter has `status: subordinate_to_workspace`. C-suite agents get an inline short-circuit so they stop reporting these as stalled. Bumps: - plugin.json: 2.1.1 -> 2.1.2 - marketplace.json: 2.1.1 -> 2.1.2 - package.json (bin): 1.7.1 -> 1.7.2 CHANGELOG entry under [2.1.2] with the concrete 2026-05-01 case that motivated the fix (COO false-flagged healify-api v3.1 Phase 1 as stalled on a PR that was intentionally superseded). No breaking changes; drop-in replacement for 2.1.1.
Summary
When a GSD project's STATE.md frontmatter has
status: subordinate_to_workspace, its phase tracking is intentionally delegated to a workspace-level coordinator. C-suite YOLO agents were treating these as independent and flagging them as 'stalled' when their phase progress was static — but the staticness is correct: the workspace owns the schedule.Adds a header annotation
[SUBORDINATE — tracking delegated to workspace; do NOT flag as stalled]so the C-suite agents have an inline short-circuit. Pairs with the CLAIM VERIFICATION GUARDRAIL from #202.Concrete case (2026-05-01 YOLO session)
COO claimed
healify-api v3.1 Phase 1 stalled 6d on closed PR #3217. Reality: #3217 was intentionally closed and superseded by #3222 (merged 2026-04-25). The workspace-level STATE.md reflects this withstatus: subordinate_to_workspace; the YOLO scan would have surfaced that status if the script annotated it.Implementation
subordinate_to_workspaceset -eregression)Test plan
bin/ops-gsd-states | grep ===correctly tagshealify-agentcore(subordinate) but not active projectsset -euo pipefailregressionNote
Low Risk
Low risk: small change to a reporting script that only adjusts output formatting based on optional
STATE.mdfrontmatter, with a|| trueguard to avoidset -efailures.Overview
ops-gsd-statesnow parses YAML frontmatter in each project’s.planning/STATE.mdto read thestatusfield, and appends a SUBORDINATE annotation to the printed header whenstatus: subordinate_to_workspace.This adds a small
awk-basedfrontmatter_valuehelper and keeps behavior unchanged for projects without that status (or when parsing fails), aside from the new header tag.Reviewed by Cursor Bugbot for commit 57a449a. Bugbot is set up for automated code reviews on this repo. Configure here.