Replace Ubuntu 16.04 with CentOS 7 for prebuilds#674
Conversation
* Remove prebuild settings from standard "linux" job * Add centos7 job with prebuild settings * Add centos7-devtoolset7 docker image prebuild script Ref: prebuild/docker-images#8 Ref: #672
|
Thanks so much for this! For me the main concerns are:
Once prebuild/docker-images#8 is available in Docker Hub, we'll do a test release here and evaluate. |
| - os: osx | ||
| node_js: node | ||
| env: [TEST=1, TEST_ELECTRON=1, BUILD_CMD=prebuild, BUILD_GROUP=darwin-x64] |
There was a problem hiding this comment.
@vweevers Side note. Why isn't osx using if: tag is present?
There was a problem hiding this comment.
Because that job runs tests too
There was a problem hiding this comment.
My understanding of this is that if: tag is present says "only invoke this if the current commit is tagged, so is probably a release that needs a prebuild". Otherwise it's just a normal test run. So osx gets test runs and prebuilds, but the prebuild-only jobs (arm and alpine) only get invoked when you need a prebuild and they don't get tests.
Maybe it's a good idea to also invoke alpine and centos7 builds on normal commits, not just tagged ones, and run the tests as well inside those containers?
There was a problem hiding this comment.
Running tests in docker containers would make build times too long IMO.
vweevers
left a comment
There was a problem hiding this comment.
I propose we do a prerelease (and test the result on a bunch of platforms).
Sounds good! |
|
Build time is excellent:
|
Using the new prebuildify-cross (prebuild/prebuildify-cross#7). This makes the prebuilt binary for linux compatible with Debian 8, Ubuntu 14.04, RHEL 7, CentOS 7 and other flavors with an old glibc. Following Level/leveldown#674.
This makes the prebuilt binary for linux compatible with Debian 8, Ubuntu 14.04, RHEL 7, CentOS 7 and other flavors with an old glibc. Following Level/leveldown#674. This rocksdb PR additionally uses the new prebuildify-cross (prebuild/prebuildify-cross#7). That's a github dependency for now; waiting for npm ownership.
This makes the prebuilt binary for linux compatible with Debian 8, Ubuntu 14.04, RHEL 7, CentOS 7 and other flavors with an old glibc. Following Level/leveldown#674. This rocksdb PR additionally uses the new prebuildify-cross (prebuild/prebuildify-cross#7). That's a github dependency for now; waiting for npm ownership.
Ref: prebuild/docker-images#8
Ref: #672
For your consideration, no pressure on this if it's reaching too far, I won't be upset if you don't like it!