This repository was archived by the owner on Dec 1, 2024. It is now read-only.
Merged
Conversation
Member
|
👍 |
Member
|
This motivates a |
Contributor
Author
|
Probably a good idea to upgrade anyways though :) Still not sure what the issue is with #157. I had a modified version of levelup that prevented close from being called until put was finished, but that should likely be handled in leveldown (and it looks like that's how it's supposed to work). |
Member
|
I believe the issue with #157 is a race condition. The db is destroyed before operations that are in flight have finished. It's a known issue. |
Member
|
lgtm, and +1 for minor |
Member
|
@braydonf Mind rebasing this onto latest master? Time to update this baby now! |
54c20d1 to
9ed4d81
Compare
Contributor
Author
|
Rebased |
Member
|
cheers! published as 1.3.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrading to LevelDB 1.18.0 seems to resolve issue #157Edit: Scratch that, doesn't resolve #157