Skip to content
This repository was archived by the owner on Dec 1, 2024. It is now read-only.
/ abstract-leveldown Public archive

Add db.getMany(keys)#381

Merged
vweevers merged 3 commits intomasterfrom
get-many
Sep 28, 2021
Merged

Add db.getMany(keys)#381
vweevers merged 3 commits intomasterfrom
get-many

Conversation

@vweevers
Copy link
Member

@vweevers vweevers commented Sep 25, 2021 •
edited
Loading

Tested against leveldown, memdown, level-js, deferred-leveldown, encoding-down, (indirectly) levelup, subleveldown.

Ref Level/community#101

@vweevers vweevers added enhancement New feature or request semver-minor New features that are backward compatible labels Sep 25, 2021
This was referenced Sep 25, 2021
Closed
Closed
vweevers
vweevers commented Sep 25, 2021
View reviewed changes
abstract-leveldown.js

this._getMany(serialized, options, callback)
return callback.promise
}
Copy link
Member Author

@vweevers vweevers Sep 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that here we're doing everything that levelup normally does, as an experiment.

Copy link
Member Author

@vweevers vweevers Sep 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which means that levelup only has to do this:

LevelUP.prototype.getMany = function (keys, options, callback) {
  return this.db.getMany(keys, options, callback)
}

Copy link
Member

@ralphtheninja ralphtheninja Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So later on we can move over the catering stuff to abstract-leveldown one by one.

vweevers
vweevers commented Sep 25, 2021
View reviewed changes
vweevers
vweevers commented Sep 25, 2021
View reviewed changes
@vweevers vweevers mentioned this pull request Sep 25, 2021
Closed
15 tasks
This was referenced Sep 25, 2021
Merged
Merged
Merged
Merged
This was referenced Sep 25, 2021
Merged
Closed
@vweevers
Copy link
Member Author

vweevers commented Sep 28, 2021 •
edited
Loading

Added in the last commit (1f1ab97):

  • AbstractLevelDOWN.prototype.isOperational() which returns true if the db accepts operations. Normally that means when db.status is 'open', and deferred-leveldown can override _isOperational() to also accept operations when db.status is 'opening'.
  • More tests

And removed:

vweevers added a commit to Level/subleveldown that referenced this pull request Sep 28, 2021
@vweevers
Add db.getMany(keys)
fb1c5a4 
Ref Level/community#101.

Depends on:

- Level/abstract-leveldown#381
- Level/memdown#212
- Level/levelup#725
- Level/encoding-down#102
@vweevers vweevers mentioned this pull request Sep 28, 2021
Merged
@vweevers vweevers merged commit e4445a7 into master Sep 28, 2021
vweevers added a commit to Level/subleveldown that referenced this pull request Oct 1, 2021
@vweevers
Add db.getMany(keys)
4378a8f 
Ref Level/community#101.

Depends on:

- Level/abstract-leveldown#381
- Level/memdown#212
- Level/levelup#725
- Level/encoding-down#102
@vweevers vweevers deleted the get-many branch October 1, 2021 13:27
vweevers added a commit to Level/subleveldown that referenced this pull request Oct 1, 2021
@vweevers
Add db.getMany(keys) (#107)
0ff2b68 
Ref Level/community#101.

Depends on:

- Level/abstract-leveldown#381
- Level/memdown#212
- Level/levelup#725
- Level/encoding-down#102
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@juliangruber juliangruber Awaiting requested review from juliangruber

1 more reviewer

@ralphtheninja ralphtheninja ralphtheninja approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request semver-minor New features that are backward compatible

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vweevers @ralphtheninja