Export leaflet version as string replaced via rollup#9662
Conversation
|
With that change we could also remove the |
847a92a to
df22fe7
Compare
Yeah. I've removed them. |
|
The down side of this approach is, that for the not bundled version, the version is always |
|
Yeah, true. I've amended this PR and search and replace |
|
@simon04 did you push? I don't see any changes |
df22fe7 to
0314f28
Compare
|
Err, not to this branch (was considering a separate branch for a moment). Pushed now. |
Falke-Design
left a comment
There was a problem hiding this comment.
LGTM
waiting for a second approval
|
Sorry for the ping @jonkoops @IvanSanchez @mourner - I’d like to proceed with version 2. |
|
@Falke-Design @simon04 Please remind me - what's the rationale for ditching the current rollup plugins approach? Compatibility issues with 2025 toolchains? I'm kinda against using |
|
Hi, see #9609 (comment). At the moment, the entire content of package.json ends up in the dist bundle. |
|
@IvanSanchez the goal would be to be able to access the classes directly without the bundle. |
|
I don't like "latest" that much either. We could always overwrite the |
|
I'd rather have something like Also, can you folks try out if the |
|
The named export was in use prior to #9609. But browsers (running the non-bundled code while testing) do not support named imports, see #9609 (comment). |
|
Thanks for the suggestion but I just merged #9717 |
Supersedes #9657.