Export leaflet version via createBanner#9657
Conversation
Replaces package.json import, and rollup-plugin-json, and rollup-plugin-git-version.
|
We made Leaflet importable without the need to bundle it. When I understand your changes correctly, the version would be now never be exported in an unbundled import |
|
And the |
Is not ideal, that is true |
True. Sorry, I did not consider "Leaflet importable without the need to bundle it" for this PR.
What about writing a |
There should be a better way to do this, but I have no other idea ... How are doing this other repos? @jonkoops any ideas how we can export the |
|
Here's what OpenLayers is doing: https://github.com/openlayers/openlayers/blob/5a8bd452e8a7a0fe55cab268cdceb0b642985fdc/tasks/set-version.js updates |
|
@simon04 okay thank you. Can you prepare something similar? |
|
Superseded by #9662. |
Replaces package.json import, and rollup-plugin-json, and rollup-plugin-git-version.