feat(vue): enabled hybrid mode to avoid 2 typescript lsp running at same time#3908
Merged
folke merged 3 commits intoLazyVim:mainfrom Jul 5, 2024
RayGuo-ergou:hotfix/vue_lsp_perf_issue
Merged
feat(vue): enabled hybrid mode to avoid 2 typescript lsp running at same time#3908folke merged 3 commits intoLazyVim:mainfrom RayGuo-ergou:hotfix/vue_lsp_perf_issue
folke merged 3 commits intoLazyVim:mainfrom
RayGuo-ergou:hotfix/vue_lsp_perf_issue
Conversation
Collaborator
|
if hybrid mode is the way to go, then this should be configured to just that. ty |
Contributor
|
Expect to see that in the next release. @folke 🙂 |
Collaborator
|
@RayGuo-ergou can you update the PR to always use hybrid mode? It does not need to be configurable. |
Contributor
Author
|
Hi @folke done! |
Collaborator
|
ty! |
folke
pushed a commit
that referenced
this pull request
Jul 5, 2024
🤖 I have created a release *beep* *boop* --- ## [12.26.0](v12.25.0...v12.26.0) (2024-07-05) ### Features * **dial:** yaml support ([f64bbd2](f64bbd2)) * **util:** rest-client ([#3915](#3915)) ([76b41cd](76b41cd)) * **vue:** enabled hybrid mode to avoid 2 typescript lsp running at same time ([#3908](#3908)) ([4b0f720](4b0f720)) ### Bug Fixes * **dial:** move date related augends to default group ([#3927](#3927)) ([4192d95](4192d95)) * **outline:** use the correct symbols and filter config format ([#3924](#3924)) ([502dac1](502dac1)) * **project:** properly close window after changing directory ([#3919](#3919)) ([51e99df](51e99df)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
At the moment, the config for vue set hybrid mode to
falsewhich volar will run a typescript server under the hook. ( hybrid mode false is the takeover mode in v1, was introduced in2.0.7see more information here: vuejs/language-tools#4119 ).However, another vtsls with vue language plugin also attached to vue files, this will cause two typescript server running at the same time. It can be very easily observed with tools like
htopvolar and vtsls will have similar memory usage which is abnormal because volar should be very light by itself. This will introduce issues like duplicate diagnostics, see vuejs/language-tools#4159 (comment)In this pull request, I set the hybrid mode to true as default because the hybrid mode is the "correct" way moving forward, thus it would be more stable. Let me know if you feel it should stay as
falseto be default.Does this PR fix an existing issue?
No existing issue.
Checklist