refactor(core): remove class type check when clearing cache in deps tracker (angular#51293)

pmvald · pkozlowski-opensource · commit a9f609e75cc7 · 2023-08-14T08:57:32.000-07:00
Using verification helpers such as `isComponent` may trigger JIT compilation. Now in some tests such compilation is made purposely to fail, and so in such cases any reference to the `depsTracker.clearScopeCacheFor` method will cause the exception to be thrown earlier than expected which results in teh test failure. Such scenario is the case in the next commit when we enable using the deps tracker in the jit compilation. Note that such failure is only for the framework tests and is a very edge case. The tests in downstream apps will not lead to such scenario of failure at all. PR Close angular#51293
diff --git a/packages/core/src/render3/deps_tracker/deps_tracker.ts b/packages/core/src/render3/deps_tracker/deps_tracker.ts
@@ -124,11 +124,8 @@ class DepsTracker implements DepsTrackerApi {
 
   /** @override */
   clearScopeCacheFor(type: Type<any>): void {
-    if (isNgModule(type)) {
-      this.ngModulesScopeCache.delete(type);
-    } else if (isComponent(type)) {
-      this.standaloneComponentsScopeCache.delete(type);
-    }
+    this.ngModulesScopeCache.delete(type as NgModuleType);
+    this.standaloneComponentsScopeCache.delete(type as ComponentType<any>);
   }
 
   /** @override */
