Skip to content

Harden Snow iframes clashing and protection#128

Merged
weizman merged 1 commit intomainfrom
xxx
Jul 17, 2023
Merged

Harden Snow iframes clashing and protection#128
weizman merged 1 commit intomainfrom
xxx

Conversation

@weizman
Copy link
Copy Markdown
Member

@weizman weizman commented Jul 17, 2023

This PR continues:

Context goes further in fix attempts #121 and #124, this PR is an extension of the attempt done in #124 mostly, by:

  • making sure "skip" is only relevant to the top and not all windows
  • making sure passing the correct window to top.SNOW actually happens

@weizman weizman changed the title attempt fix Harden Snow iframes clashing and protection Jul 17, 2023
@weizman weizman marked this pull request as ready for review July 17, 2023 15:32
@weizman weizman merged commit b28db05 into main Jul 17, 2023
@weizman weizman deleted the xxx branch July 17, 2023 15:43
@weizman weizman mentioned this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant