Skip to content

Fix clash when Snow loads in same origin realm and is also called within it (continue #97)#121

Merged
weizman merged 1 commit intomainfrom
fix-issue-97-2
Jul 16, 2023
Merged

Fix clash when Snow loads in same origin realm and is also called within it (continue #97)#121
weizman merged 1 commit intomainfrom
fix-issue-97-2

Conversation

@weizman
Copy link
Copy Markdown
Member

@weizman weizman commented Jul 16, 2023

attempt to fix an extension of the problem introduced at #97 (comment)

  • define SNOW prop for same window, not top
  • make sure that if Snow was already called once on top, it shouldn't reapply all patches, but only call the new cb on top

@weizman weizman changed the title fix attempt 97 2nd Fix clash when Snow loads in same origin realm and is also called within it (continue #97) Jul 16, 2023
@weizman weizman marked this pull request as ready for review July 16, 2023 11:04
@weizman weizman merged commit 93758f5 into main Jul 16, 2023
@weizman weizman deleted the fix-issue-97-2 branch July 16, 2023 11:05
This was referenced Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant