lift <19 nodejs restriction for pkgs not depending on core#586
Merged
Conversation
leotm
approved these changes
May 18, 2023
leotm
requested changes
May 18, 2023
leotm
left a comment
Member
There was a problem hiding this comment.
after further thought, what do we think about expanding this change to include other packages?
nb: tested linting and tests on node v20 locally for aa and thanks for our pair programming call
Collaborator
Author
|
Changing scope of this PR to lift all relevant packages in monorepo. |
aec9f77 to
c06f585
Compare
legobeat
added a commit
to legobeat/LavaMoat
that referenced
this pull request
May 18, 2023
The restriction was introduced across the monorepo in 82beffa (LavaMoat#552) as response to a regression in `lavamoat-core`. This lifts the restriction for unaffected packages without dependencies on core. M package.json M packages/allow-scripts/package.json M packages/preinstall-always-fail/package.json M packages/tofu/package.json
c06f585 to
f28a7bb
Compare
legobeat
added a commit
to legobeat/LavaMoat
that referenced
this pull request
May 18, 2023
…avaMoat#586) The restriction was introduced across the monorepo in 82beffa (LavaMoat#552) as response to a regression in `lavamoat-core`. This lifts the restriction for unaffected packages without dependencies on core. - lavamoat-monorepo - @lavamoat/allow-scripts - @lavamoat/preinstall-always-fail - @lavamoat/yarn-plugin-allow-scripts - lavamoat-tofu
f28a7bb to
492a8e8
Compare
…avaMoat#586) The restriction was introduced across the monorepo in 82beffa (LavaMoat#552) as response to a regression in `lavamoat-core`. This lifts the restriction for unaffected packages without dependencies on core. - lavamoat-monorepo - @lavamoat/allow-scripts - @lavamoat/preinstall-always-fail - @lavamoat/yarn-plugin-allow-scripts - lavamoat-tofu
492a8e8 to
cbcee6e
Compare
Member
|
+1 to larger PRs covering the same/similar change across many packages |
naugtur
approved these changes
May 19, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lavamoat/aais