Prelint cleanup #397#399
Closed
legobeat wants to merge 6 commits into
Closed
Conversation
naugtur
approved these changes
Nov 14, 2022
naugtur
reviewed
Nov 14, 2022
|
|
||
|
|
||
| const { DepGraph } = require('./graphs/DepGraph') | ||
| const { DepGraph } = require('./graphs/DepGraph.js') |
Member
There was a problem hiding this comment.
This line is weird...
@kumavis why is there a mix of import and require in one file?
Collaborator
Author
There was a problem hiding this comment.
Indeed. Do we want to consider enabling no-var-requires/no-require-imports as well?
Member
There was a problem hiding this comment.
haha idk! viz is getting old and dusty
0013600 to
5470b13
Compare
Collaborator
Author
|
Updated to comply with new rules in #397 |
5470b13 to
c4954fd
Compare
Merged
Member
|
merged in #409 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor fixups to make the new linting configuration in #397 pass. Not much! 🏅