update eslint configuration#397
Conversation
| "lint:deps": "depcheck" | ||
| }, | ||
| "engines": { | ||
| "node": ">=12.0.0" |
There was a problem hiding this comment.
This was added to address a node/no-unsupported-features/node-builtins linting error. However, I think there's more to this.
It looks like some of the code actually uses some features not in node v12, alread (note: would be good to address those don't get caught in linting, too).
One straight-forward way to resolve this would be to add a constraint to engines.node: ">=14.x" is added to package.json for each subpackage. So how to treat that comes down to if support for node v12 is actually still desired at this point.
There was a problem hiding this comment.
Addressed with separate proposal in #398
| const JSONStream = require('JSONStream') | ||
| const through = require('through2') | ||
| const umd = require('umd') | ||
| // eslint-disable-next-line node/prefer-global/buffer |
There was a problem hiding this comment.
Is there some subtlety making the require('buffer') necessary? If not it seems better to just remove it.
1665f33 to
dab4caf
Compare
Much of es2021 is not supported in node v14 https://kangax.github.io/compat-table/es2016plus/ Fortunately, no changes needed to enforce this.
4028d82 to
b69648c
Compare
|
Added rules:
|
|
merged in #409 |
@metamask/eslint-config-nodejs..eslintIgnore(fun fact:!-negative-filters don't work elsewhere)outstanding questions:
.depcheckrc.ignoresand what goes indevDependencies?avavseslint?