Skip to content

feat(react-native-lockdown): use vendored SES version#1716

Merged
naugtur merged 5 commits into
mainfrom
leotm/react-native-lockdown-use-vendored-ses-2855
Jun 23, 2025
Merged

feat(react-native-lockdown): use vendored SES version#1716
naugtur merged 5 commits into
mainfrom
leotm/react-native-lockdown-use-vendored-ses-2855

Conversation

@leotm

@leotm leotm commented Jun 17, 2025

Copy link
Copy Markdown
Member

Use vendored SES version

Then replace with next SES release once that's out

@github-actions github-actions Bot added the dependencies Pull requests that update a dependency file label Jun 17, 2025
@leotm leotm marked this pull request as ready for review June 17, 2025 10:19
@leotm leotm force-pushed the leotm/react-native-lockdown-use-vendored-ses-2855 branch from 758c207 to 2e3ff49 Compare June 17, 2025 10:36
Comment thread .eslintrc.js Outdated
Comment thread packages/react-native-lockdown/vendor/ses-hermes.cjs Outdated
@leotm leotm force-pushed the leotm/react-native-lockdown-use-vendored-ses-2855 branch from 62ffb6d to e33396a Compare June 18, 2025 14:23
@naugtur naugtur merged commit 34d8b67 into main Jun 23, 2025
15 checks passed
@naugtur naugtur deleted the leotm/react-native-lockdown-use-vendored-ses-2855 branch June 23, 2025 10:48
@github-actions github-actions Bot mentioned this pull request Jun 24, 2025
github-merge-queue Bot pushed a commit to MetaMask/metamask-mobile that referenced this pull request Jul 9, 2025
## **Description**

Introduce Hardened JavaScript now on both iOS (RN JSC) and Android
(Hermes)
via Metro (@lavamoat/react-native-lockdown beta) instead of RN patch
and remove [old iOS
UI](https://github.com/user-attachments/assets/b53be562-bc36-4ff2-a177-ef5c24c44de4)
from: Settings > Experimental > Security

TODO
- [x] Remove stale root SES shim (now via
@lavamoat/react-native-lockdown)
- [x] Remove stale RN iOS patch (now via
@lavamoat/react-native-lockdown)
- [x] Add temp @lavamoat/react-native-lockdown tgz
- [x] Add temp SES patch endojs/endo#2855
- [x] Replace both with official @lavamoat/react-native-lockdown
  - [x] once LavaMoat/LavaMoat#1716 merged
  - [x] released LavaMoat/LavaMoat#1643
- [x] Remove experimental feature toggle UI
  - Ref: #8373
    - preserve react-native-mmkv (we still use it)
    - update UI component snapshot
    - remove stale EN txt (and others?)
- [x] <s>Fix smoke/regression e2e test timeouts</s> passing
- [x] check failing regression e2e tests
  - same ones also failing on `main`
- [x] cursor[bot] feedback

## **Related issues**

Fixes:

## **Manual testing steps**

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants