feat(react-native-lockdown): use vendored SES version#1716
Merged
Conversation
758c207 to
2e3ff49
Compare
naugtur
reviewed
Jun 17, 2025
naugtur
reviewed
Jun 17, 2025
19 tasks
62ffb6d to
e33396a
Compare
naugtur
approved these changes
Jun 23, 2025
Merged
github-merge-queue Bot
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Jul 9, 2025
## **Description** Introduce Hardened JavaScript now on both iOS (RN JSC) and Android (Hermes) via Metro (@lavamoat/react-native-lockdown beta) instead of RN patch and remove [old iOS UI](https://github.com/user-attachments/assets/b53be562-bc36-4ff2-a177-ef5c24c44de4) from: Settings > Experimental > Security TODO - [x] Remove stale root SES shim (now via @lavamoat/react-native-lockdown) - [x] Remove stale RN iOS patch (now via @lavamoat/react-native-lockdown) - [x] Add temp @lavamoat/react-native-lockdown tgz - [x] Add temp SES patch endojs/endo#2855 - [x] Replace both with official @lavamoat/react-native-lockdown - [x] once LavaMoat/LavaMoat#1716 merged - [x] released LavaMoat/LavaMoat#1643 - [x] Remove experimental feature toggle UI - Ref: #8373 - preserve react-native-mmkv (we still use it) - update UI component snapshot - remove stale EN txt (and others?) - [x] <s>Fix smoke/regression e2e test timeouts</s> passing - [x] check failing regression e2e tests - same ones also failing on `main` - [x] cursor[bot] feedback ## **Related issues** Fixes: ## **Manual testing steps** ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use vendored SES version
cd packages/ses && yarn run buildThen replace with next SES release once that's out