-
Notifications
You must be signed in to change notification settings - Fork 3
sync: merge upstream v1.0.134 #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Github Action <action@github.com> Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com> Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com>
Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
…ot explicitly defined
Co-authored-by: Github Action <action@github.com> Co-authored-by: Dax Raad <d@ironbay.co>
This reverts commit d763c11.
This reverts commit f9dcd97.
Provider credentials field was being selected from ProviderTable even when the table wasn't joined (when byokProvider was undefined). Now the join is conditional - when byokProvider exists, we join and get the credentials; when it doesn't, the join condition is always false so provider remains null.
Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com>
…ion (anomalyco#5086) Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
…nomalyco#4978) Co-authored-by: noamzbr <noamzbr@users.noreply.github.com> Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: rekram1-node <rekram1-node@users.noreply.github.com>
Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: rekram1-node <rekram1-node@users.noreply.github.com>
…mall timeout issue (anomalyco#5131)
Co-authored-by: Adam <2363879+adamdotdevin@users.noreply.github.com>
Resolved conflicts: - .github/workflows/duplicate-issues.yml: deleted (keep ours) - .github/workflows/publish.yml: deleted (keep ours) - STATS.md: accept upstream - bun.lock: regenerated - github/action.yml: keep fork-specific OPENCODE_BIN_PATH - packages/console/*/package.json: accept upstream versions - packages/console/app/src/routes/zen/util/handler.ts: accept upstream - packages/console/core/src/model.ts: accept upstream (byokProvider) - packages/desktop/package.json: accept upstream version - packages/enterprise/package.json: accept upstream version - packages/extensions/zed/extension.toml: accept upstream version - packages/function/package.json: accept upstream version - packages/opencode/package.json: accept upstream version - packages/opencode/src/agent/agent.ts: merge both (keep subagents + add maxSteps) - packages/opencode/src/cli/cmd/tui/component/prompt/index.tsx: keep fork text getter - packages/opencode/src/cli/cmd/tui/routes/session/index.tsx: keep fork features - packages/opencode/src/provider/provider.ts: accept upstream sap-ai-core getModel - packages/opencode/src/tool/bash.ts: accept upstream - packages/plugin/package.json: accept upstream version - packages/sdk/js/package.json: accept upstream version - packages/slack/package.json: accept upstream version - packages/tauri/package.json: accept upstream version - packages/ui/package.json: accept upstream version - packages/util/package.json: accept upstream version - packages/web/package.json: accept upstream version - sdks/vscode/package.json: accept upstream version
|
Caution Review failedThe pull request is closed. WalkthroughThis PR bumps the version to v1.0.134 and introduces substantial desktop/terminal infrastructure, including a new Terminal UI component with WebSocket-based PTY management, serialization capabilities, configuration options for max steps and OpenTelemetry telemetry, refactored authentication flows in Zen model selection, Tauri build integration, and incremental UI improvements across tabs, select, and icon components. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Terminal Component
participant Session Context
participant WebSocket
participant PTY Server
participant SDK Client
User->>Terminal Component: Mount (with SDK URL & PTY ID)
Terminal Component->>Session Context: Retrieve PTY state (buffer, size, scrollY)
Terminal Component->>WebSocket: Connect to /pty/:id/connect
WebSocket->>PTY Server: Upgrade connection
PTY Server->>Terminal Component: Send buffered output
Terminal Component->>Terminal Component: Restore state (buffer, size, scroll)
User->>Terminal Component: Type/Resize/Input
Terminal Component->>WebSocket: Send input data
WebSocket->>PTY Server: Forward to PTY session
PTY Server->>PTY Server: Execute, capture output
PTY Server->>WebSocket: Stream data
WebSocket->>Terminal Component: Receive output
Terminal Component->>Terminal Component: Render to screen
Terminal Component->>Session Context: on(resize): Update PTY state
Session Context->>SDK Client: pty.update({ id, cols, rows })
User->>Terminal Component: Unmount/Close
Terminal Component->>Terminal Component: Serialize (serialize addon)
Terminal Component->>Session Context: Save PTY state (buffer, size, scrollY)
Terminal Component->>WebSocket: Close
WebSocket->>PTY Server: Close connection & cleanup
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Areas requiring close attention:
Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (57)
📒 Files selected for processing (82)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Conflicts Resolved
.github/workflows/*STATS.mdbun.lockgithub/action.ymlpackages/*/package.jsonpackages/opencode/src/agent/agent.tspackages/opencode/src/cli/cmd/tui/**/*.tsxCloses #89
Summary by CodeRabbit
New Features
Bug Fixes
UI Improvements
Chores
✏️ Tip: You can customize this high-level summary in your review settings.