packages/opencode/src/cli/cmd/tui/component/dialog-model.tsx (1)

205-211: Guard favorite toggle to only operate on model entries.

The ctrl+f keybind handler casts option.value to { providerID: string; modelID: string } without verification. When !connected(), provider options from lines 180-191 are included with a different value shape. Hitting ctrl+f on a provider option will cause a runtime error or corrupt favorites.

Apply the type guard suggested in the previous review to prevent this:

 {
   keybind: Keybind.parse("ctrl+f")[0],
   title: "Favorite",
   onTrigger: (option) => {
+    const value = option.value as any
+    if (
+      !value ||
+      typeof value.providerID !== "string" ||
+      typeof value.modelID !== "string"
+    ) {
+      return
+    }
-    local.model.toggleFavorite(option.value as { providerID: string; modelID: string })
+    local.model.toggleFavorite(value)
   },
 },

Based on past review comments.

packages/opencode/src/cli/cmd/tui/context/local.tsx (1)

130-138: Add error handling for file write operations.

The save() function calls Bun.write() without handling promise rejection. If the write fails (disk full, permissions, I/O errors), the failure will be silent, leading to potential data loss without user feedback.

Apply this diff to add error handling:

 function save() {
   Bun.write(
     file,
     JSON.stringify({
       recent: modelStore.recent,
       favorite: modelStore.favorite,
     }),
-  )
+  ).catch((error) => {
+    toast.show({
+      variant: "error",
+      message: `Failed to save model preferences: ${error.message}`,
+      duration: 5000,
+    })
+  })
 }

Based on past review comments.

UPSTREAM-SYNC-PLAN.md (2)

9-19: Add language specifier to code block.

The ASCII diagram block at line 9 should explicitly specify a language (e.g., text) to comply with markdown linting standards.

-```
+```text
 integration (DEFAULT)  ← Your working branch, custom features, workflow configs
      ↑
      │ merge
      │
    dev (MIRROR)        ← Read-only mirror of upstream release tags
      ↑
      │ hard reset
      │
 upstream/tags          ← sst/opencode release tags
-```
+```

---

265-327: Add language specifier to ASCII diagram code block.

The workflow diagram at line 265 should explicitly specify a language (e.g., text) to comply with markdown linting standards.

-```
+```text
 ┌─────────────────┐
 │ Schedule/Manual │
 ...
     [Workflow End]
-```
+```

packages/opencode/src/cli/cmd/tui/component/dialog-model.tsx (1)

28-54: Consider extracting ordering logic into helper functions.

The ordering logic for orderedRecents, orderedFavorites, and orderedRecentList is correct but dense. Extracting these into named helper functions would improve readability and testability.

Example refactor:

function orderWithCurrentFirst<T extends { providerID: string; modelID: string }>(
  items: T[],
  current: { providerID: string; modelID: string } | undefined
): T[] {
  if (!current) return items
  return [
    ...items.filter(item => isCurrent(item, current)),
    ...items.filter(item => !isCurrent(item, current))
  ]
}

function isCurrent(
  item: { providerID: string; modelID: string },
  current: { providerID: string; modelID: string }
) {
  return item.providerID === current.providerID && item.modelID === current.modelID
}

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro