docs: remove stale Signature Verification section#3
Closed
samyakLambda wants to merge 1 commit intomainfrom
Closed
docs: remove stale Signature Verification section#3samyakLambda wants to merge 1 commit intomainfrom
samyakLambda wants to merge 1 commit intomainfrom
Conversation
The section instructed users to download kane-cli-linux-x64.sig and public_key.pem from GitHub Releases to manually verify the binary's OpenSSL signature. Now that npm/brew/curl all install via the @testmuai/kane-cli npm package, regular users never touch the bare release binaries — the section was misleading. The macOS/Windows subsections were also trivially true (Gatekeeper / SmartScreen verify automatically) and added no actionable info. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
We have this and can be used to verify |
samyakLambda
added a commit
that referenced
this pull request
Apr 28, 2026
Pivots the README from describing an in-package Chrome-for-Testing
download (~150 MB to ~/.cache/kane-cli/chrome) to the actual behavior
shipping in 0.3.0+: kane-cli requires real Google Chrome stable at the
standard system paths.
- Drops "Cold start downloads Chrome" framing from the npx section.
Replaces with a brief "requires Node 18+ and Google Chrome" note.
- Renames "About Chrome" -> "Chrome (required)" and rewrites contents
to describe the per-platform postinstall behavior:
* Homebrew auto-installs via the google-chrome cask (formula PR #3)
* macOS npm/npx attempts `brew install --cask google-chrome`
* Linux/Windows npm/npx prints install instructions
* KANE_CLI_CHROME_PATH and KANE_CLI_SKIP_BROWSER_DOWNLOAD escape hatches
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the README "Signature verification" section. It instructed users to download `kane-cli-linux-x64.sig` and `public_key.pem` from GitHub Releases to manually verify the binary's OpenSSL signature.
Why
Now that npm / brew / curl all install via the `@testmuai/kane-cli` npm package (#1, #2), regular users never touch the bare release binaries — the section pointed at artifacts they don't have.
The macOS/Windows subsections were also trivially true (Gatekeeper / SmartScreen verify automatically on first launch) and added no actionable info.
Note
Release artifacts and `public_key.pem` still exist on GitHub Releases for advanced users who want to verify the bare runner directly. We can document that path separately later if there's demand.
🤖 Generated with Claude Code