Allowing for cross-correlations in HOD power spectrum.#1224
Merged
Conversation
Collaborator
|
The code is fine, but there's a problem with conda. I'm trying to fix it, give me a few min (hopefully). |
damonge
requested changes
Feb 13, 2025
pyccl/tests/test_profiles.py
Outdated
| p2.fourier_2pt(COSMO, 1., 1E13, 1., pgood, prof2=pgood_b) | ||
| # doesn't raise for two different HOD profiles | ||
| pgood_b.update_parameters(log10M0_0=10.) | ||
| p2.fourier_2pt(COSMO, 1., 1E13, 1., pgood, prof2=pgood_b) |
Collaborator
There was a problem hiding this comment.
Can we check that this gives the same result as the standard profile2pt?
Contributor
Author
There was a problem hiding this comment.
Thank you for going through the code and the comments David. Should be fixed now.
RyoTerasawa
added a commit
that referenced
this pull request
Feb 13, 2025
Allowing for cross-correlations in HOD power spectrum. (#1224)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows for cross-correlations with different HOD profiles. In the case in which the profiles are different, the code reverts to the usual Fourier-space two-point moment as implemented in Profile2pt. This holds under the assumption that the two tracers are disjoint.