Skip to content

Background Calculations#1149

Merged
hsinfan1996 merged 156 commits intomasterfrom
distances_v3_revive
Jan 2, 2024
Merged

Background Calculations#1149
hsinfan1996 merged 156 commits intomasterfrom
distances_v3_revive

Conversation

@hsinfan1996
Copy link
Contributor

@hsinfan1996 hsinfan1996 commented Dec 21, 2023 •
edited
Loading

Merge distances_v3 branch into master (different from PR #1066 ). Closes issue #954 andd #408 .

nikfilippas and others added 30 commits March 16, 2023 06:06
@nikfilippas
first commit
0c68867
@nikfilippas
Merge branch 'master' into CCLObject_eq
790bc13
@nikfilippas
remove warning in the first spin of CCL
437f5df
@nikfilippas
kernels chk ok, transfers almost done
12961f4
@nikfilippas
more tests
52df271
@nikfilippas
halo profiles in their own directory
87c8639
@nikfilippas
finished tracer eq tests
1bfab13
@nikfilippas
ported changes in halos/profiles
c510aca
@damonge
Merge branch 'master' into v3_wip
9474b15
@nikfilippas
concentrations in their own directory
b8bb8e9
@nikfilippas
mass functions & halo biases in their own directory
c40cf0c
@nikfilippas
moved CIB stuff to profiles & 2pts
4da043f
@nikfilippas
split halo model into 1/2/4-pt
ee5e535
@nikfilippas
fix imports
8c20b40
@nikfilippas
Merge branch 'v3_wip' of https://github.com/LSSTDESC/CCL into v3_wip
fa9e215
@nikfilippas
remove empty module
8f29fa2
@nikfilippas
Merge branch 'v3_wip' into halos_v3
5b84d70
@nikfilippas
fix typo
8df3d79
@nikfilippas
Merge branch 'v3_wip' into halos_v3
ad286d8
@nikfilippas
changes from star in halos/ (no tests)
2bb015c
@damonge
Baryons in v3 (#1039)
388629a 
* Added new baryons module that will deprecate old BCM
@nikfilippas
Merge branch 'v3_wip' into halos_v3
af2dcb0
@nikfilippas
refactor concentration, mass_function, halo_bias; improvements in HMC…
13c1206 
…alculator
@nikfilippas
HaloProfile subclasses & HaloProfile.normprof attribute
5d67de8
@nikfilippas
simplify imports
d8b0d85
@damonge
Tracers v3 (#1040)
ef815c4 
* Tracers in V3
@damonge
done
3267901
@nikfilippas
Merge branch 'master' into v3_wip
4162fed
@damonge
Background, boltzmann, and cls in v3 (#1041)
909695d 
* Background, boltzmann and cls in v3
@damonge
Merge branch 'v3_wip' into nu_param_power_v3
2e22ce3
hsinfan1996
hsinfan1996 commented Dec 21, 2023
View reviewed changes
@hsinfan1996
Copy link
Contributor Author

hsinfan1996 commented Dec 21, 2023

@nikosarcevic I've done merging the master branch into the revived distances_v3. Now you can try the new functions and see if the calculations are correct and maybe modify the code if you want.

@hsinfan1996 hsinfan1996 marked this pull request as ready for review December 21, 2023 14:38
@hsinfan1996 hsinfan1996 linked an issue Dec 21, 2023 that may be closed by this pull request
lookback time #1146
Closed
@hsinfan1996 hsinfan1996 mentioned this pull request Dec 22, 2023
Closed
@damonge
Copy link
Collaborator

damonge commented Dec 22, 2023

@hsinfan1996 let me know when you'd like me to review this. Right now I see the tests are still failing, but happy to help.

@damonge damonge self-requested a review December 22, 2023 17:59
@hsinfan1996
Copy link
Contributor Author

hsinfan1996 commented Dec 26, 2023

@damonge This is ready for review. Is there a way to fix the tests on macOS? I don't know why sometimes they passed but sometimes not.

@hsinfan1996
Copy link
Contributor Author

hsinfan1996 commented Dec 28, 2023 •
edited
Loading

@damonge This is ready for review. Is there a way to fix the tests on macOS? I don't know why sometimes they passed but sometimes not.

From my observation, faster test runs on macOS (typically < 25 min) will pass, slower ones (~35 min) will not. The weird thing is that the failed tests are not timed, but it is good that the problem is not likely caused by our code.

damonge
damonge requested changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@damonge damonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @hsinfan1996 (and @nikfilippas for the initial implementation). Some comments below.

@hsinfan1996 hsinfan1996 requested a review from damonge January 2, 2024 15:51
damonge
damonge approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@damonge damonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hsinfan1996 hsinfan1996 merged commit 682ba47 into master Jan 2, 2024
@hsinfan1996 hsinfan1996 deleted the distances_v3_revive branch January 2, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damonge damonge damonge approved these changes

@nikosarcevic nikosarcevic Awaiting requested review from nikosarcevic

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

lookback time Implement lookback time Add comoving volume element calculation to the background module

4 participants

@hsinfan1996 @coveralls @damonge @nikfilippas