Closed
Conversation
This was
linked to
issues
Apr 13, 2023
Closed
Collaborator
|
This is not to be reviewed until current functionality has been put in v3 form. There are several other new science implementations that take priority. |
2a52cc3 to
c8b63f1
Compare
Collaborator
|
Just doing some general cleaning of the repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following background functions:
hubble_distance(cosmo, a)comoving_volume_element(cosmo, a)comoving_volume(cosmo, a, *, solid_angle=4*pi)lookback_time(cosmo, a)age_of_universe(cosmo, a)and with that closes #954 and closes #408 and now CCL will be able to calculate every distance quantity described in Hogg's reference manual .