[Bugfix] fix the invalid image path#2899
Merged
DongDongJu merged 4 commits intoLMCache:devfrom Mar 30, 2026
Merged
Conversation
Signed-off-by: syaojun <libevent@yeah.net>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the image path for the LMCache Controller diagram in the documentation. A suggestion was made to use an absolute path from the Sphinx source root to improve maintainability and prevent potential link breakage during future file restructuring.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Jason Yao <libevent@yeah.net>
jooho-XCENA
pushed a commit
to xcena-dev/LMCache
that referenced
this pull request
Apr 2, 2026
* fix the invalid image path Signed-off-by: syaojun <libevent@yeah.net> * Apply suggestion from @gemini-code-assist[bot] Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Jason Yao <libevent@yeah.net> --------- Signed-off-by: syaojun <libevent@yeah.net> Signed-off-by: Jason Yao <libevent@yeah.net> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
jooho-XCENA
pushed a commit
to xcena-dev/LMCache
that referenced
this pull request
Apr 2, 2026
* fix the invalid image path Signed-off-by: syaojun <libevent@yeah.net> * Apply suggestion from @gemini-code-assist[bot] Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Jason Yao <libevent@yeah.net> --------- Signed-off-by: syaojun <libevent@yeah.net> Signed-off-by: Jason Yao <libevent@yeah.net> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
image path is invalid
Special notes for your reviewers:
If applicable: