[DSA] support DSA in Mooncake connector #2897
Merged
maobaolong merged 1 commit intoLMCache:devfrom Mar 29, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the MooncakeStoreConnector to use MemoryObj abstractions instead of direct PyTorch tensor operations, specifically replacing .tensor with .raw_tensor and using .data_ptr and .get_size() methods. It also replaces the hardcoded METADATA_BYTES_LEN constant with a dynamic self.remote_metadata_bytes attribute and cleans up unused imports like reduce and operator. I have no feedback to provide as no review comments were present and the changes appear consistent with the refactoring goal.
Signed-off-by: idellzheng <idellzheng@tencent.com>
2885029 to
93ba140
Compare
Collaborator
Author
|
@maobaolong @ApostaC could you help take a look? Thanks! |
maobaolong
approved these changes
Mar 28, 2026
Collaborator
maobaolong
left a comment
There was a problem hiding this comment.
LGTM thanks for this fix.
jooho-XCENA
pushed a commit
to xcena-dev/LMCache
that referenced
this pull request
Apr 2, 2026
[DSA] support DSA in Mooncake connector Signed-off-by: idellzheng <idellzheng@tencent.com>
jooho-XCENA
pushed a commit
to xcena-dev/LMCache
that referenced
this pull request
Apr 2, 2026
[DSA] support DSA in Mooncake connector Signed-off-by: idellzheng <idellzheng@tencent.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support DSA in mooncake connector.