Support l2 adapter check and improve basic_check tool #2895
Merged
chunxiaozheng merged 5 commits intoLMCache:devfrom Mar 31, 2026
Merged
Support l2 adapter check and improve basic_check tool #2895chunxiaozheng merged 5 commits intoLMCache:devfrom
chunxiaozheng merged 5 commits intoLMCache:devfrom
Conversation
Signed-off-by: baoloongmao <baoloongmao@tencent.com>
Signed-off-by: baoloongmao <baoloongmao@tencent.com>
Signed-off-by: baoloongmao <baoloongmao@tencent.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new test mode for L2 adapters and enhances existing remote and storage manager test modes by adding support for configurable object sizes, KV data types, and settle times. It also updates the performance reporting utilities to calculate and display throughput. A logic issue was identified in the new L2 adapter test script where the timing variable for the initial lookup phase is overwritten by a subsequent phase, leading to inaccurate performance reporting in the final summary.
Signed-off-by: baoloongmao <baoloongmao@tencent.com>
Collaborator
Author
|
@chunxiaozheng Would you like to help to check this PR works for the internal backend? |
jooho-XCENA
pushed a commit
to xcena-dev/LMCache
that referenced
this pull request
Apr 2, 2026
* Support l2 adapter check Signed-off-by: baoloongmao <baoloongmao@tencent.com> * Support display throughput and check specify num keys Signed-off-by: baoloongmao <baoloongmao@tencent.com> * Add settle time Signed-off-by: baoloongmao <baoloongmao@tencent.com> * fix: use separate vars for absent/exist lookup timing Signed-off-by: baoloongmao <baoloongmao@tencent.com> * Fix ut Signed-off-by: baoloongmao <baoloongmao@tencent.com> --------- Signed-off-by: baoloongmao <baoloongmao@tencent.com>
jooho-XCENA
pushed a commit
to xcena-dev/LMCache
that referenced
this pull request
Apr 2, 2026
* Support l2 adapter check Signed-off-by: baoloongmao <baoloongmao@tencent.com> * Support display throughput and check specify num keys Signed-off-by: baoloongmao <baoloongmao@tencent.com> * Add settle time Signed-off-by: baoloongmao <baoloongmao@tencent.com> * fix: use separate vars for absent/exist lookup timing Signed-off-by: baoloongmao <baoloongmao@tencent.com> * Fix ut Signed-off-by: baoloongmao <baoloongmao@tencent.com> --------- Signed-off-by: baoloongmao <baoloongmao@tencent.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
introduces a new test mode for L2 adapters and enhances existing remote and storage manager test modes by adding support for configurable object sizes, KV data types, and settle times. It also updates the performance reporting utilities to calculate and display throughput
Special notes for your reviewers:
If applicable: