[Build] add SM120 for wheel build#2873
Conversation
Signed-off-by: deng451e <838677410@qq.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the supported CUDA architectures for wheel builds by incorporating CUDA architecture 12.0, corresponding to NVIDIA's Blackwell generation (SM120). This ensures that builds can leverage the latest GPU hardware, updating both the Docker build configurations and the accompanying documentation to reflect this change. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the torch_cuda_arch_list in the Dockerfiles and README.md to include 12.0 as a CUDA compute capability. The reviewer notes that 12.0 is not a publicly known NVIDIA compute capability, suggesting this is a typo that could lead to build failures. Consequently, the updated documentation in README.md is also inaccurate. The reviewer recommends correcting the architecture list to 10.0+PTX and updating the documentation to reflect the accurate supported CUDA architectures, while also ensuring correct markdown formatting.
|
|
||
| # CUDA arch list used by torch | ||
| ARG torch_cuda_arch_list='7.0 7.5 8.0 8.6 8.9 9.0 10.0+PTX' | ||
| ARG torch_cuda_arch_list='7.0 7.5 8.0 8.6 8.9 9.0 10.0 12.0+PTX' |
There was a problem hiding this comment.
The CUDA compute capability 12.0 is being added, presumably for SM120 as per the PR title. However, 12.0 is not a publicly known NVIDIA compute capability. The latest announced architecture is Blackwell, which has a compute capability of 10.0.
This appears to be a typo and will likely cause the build to fail. If the intention was to ensure support for Blackwell (10.0), the previous value 10.0+PTX was already sufficient, as it builds SASS for 10.0 and PTX for forward compatibility.
ARG torch_cuda_arch_list='7.0 7.5 8.0 8.6 8.9 9.0 10.0+PTX'
|
|
||
| # CUDA arch list used by torch | ||
| ARG torch_cuda_arch_list='7.0 7.5 8.0 8.6 8.9 9.0 10.0+PTX' | ||
| ARG torch_cuda_arch_list='7.0 7.5 8.0 8.6 8.9 9.0 10.0 12.0+PTX' |
There was a problem hiding this comment.
The CUDA compute capability 12.0 is being added, presumably for SM120 as per the PR title. However, 12.0 is not a publicly known NVIDIA compute capability. The latest announced architecture is Blackwell, which has a compute capability of 10.0.
This appears to be a typo and will likely cause the build to fail. If the intention was to ensure support for Blackwell (10.0), the previous value 10.0+PTX was already sufficient, as it builds SASS for 10.0 and PTX for forward compatibility.
ARG torch_cuda_arch_list='7.0 7.5 8.0 8.6 8.9 9.0 10.0+PTX'
| | `max_jobs` | `2` | Max parallel jobs for build | | ||
| | `nvcc_threads` | `8` | Number of nvcc threads | | ||
| | `torch_cuda_arch_list` | `7.0 7.5 8.0 8.6 8.9 9.0 10.0+PTX` | CUDA architectures | | ||
| | `torch_cuda_arch_list` | `7.0 7.5 8.0 8.6 8.9 9.0 10.0 12.0+PTX` | CUDA architectures | |
There was a problem hiding this comment.
This documentation is being updated to include the 12.0 compute capability. As this value is likely a typo (see comments on the Dockerfiles), this documentation update would be inaccurate. Please update this line to reflect the correct list of supported CUDA architectures once confirmed. When applying the suggestion, please ensure the argument name and its value are enclosed in backticks (`) for correct markdown formatting.
| | `torch_cuda_arch_list` | `7.0 7.5 8.0 8.6 8.9 9.0 10.0 12.0+PTX` | CUDA architectures | | |
| | torch_cuda_arch_list | 7.0 7.5 8.0 8.6 8.9 9.0 10.0+PTX | CUDA architectures | |
add SM120 for wheel build Signed-off-by: deng451e <838677410@qq.com>
add SM120 for wheel build Signed-off-by: deng451e <838677410@qq.com>
What this PR does / why we need it:
Special notes for your reviewers:
If applicable: