Skip to content

[CI]: use job-level path filtering so skipped tests pass required checks#2855

Merged
sammshen merged 8 commits intoLMCache:devfrom
royyhuang:fix/ci-workflows
Mar 25, 2026
Merged

[CI]: use job-level path filtering so skipped tests pass required checks#2855
sammshen merged 8 commits intoLMCache:devfrom
royyhuang:fix/ci-workflows

Conversation

@royyhuang
Copy link
Copy Markdown
Contributor

Summary

  • Replaced workflow-level paths: / paths-ignore: triggers with job-level filtering using dorny/paths-filter@v3
  • When a workflow is skipped via paths: at the trigger level, required status checks remain pending and block the PR. By moving filtering to the job level, irrelevant jobs report as skipped which satisfies required checks.
  • Operator tests and LMCache tests are now fully separated: changes under operator/ won't trigger LMCache tests, and LMCache-only changes won't trigger operator tests.

Workflows updated

  • test.yml — LMCache Python tests skip when only operator files change
  • code_quality_checks.yml — code quality checks skip when only operator files change
  • operator_ci.yml — operator CI skips when no operator files change
  • operator_test_e2e.yml — operator E2E tests skip when no operator files change
  • publish.yml — build/test/quality jobs skip for operator-only changes; always run for releases and tag pushes

Behavior matrix

PR changes LMCache tests Operator tests Code quality Publish build
Only operator/ Skipped (passes) Runs Skipped (passes) Skipped
Only LMCache code Runs Skipped (passes) Runs Runs
Both Runs Runs Runs Runs
Release / tag push Runs Skipped Runs Runs

Test plan

  • Open a PR with only operator file changes → verify LMCache test jobs show as "skipped" (not missing/pending)
  • Open a PR with only Python file changes → verify operator test jobs show as "skipped"
  • Verify actionlint passes on all modified workflows (validated locally)

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@royyhuang royyhuang changed the title [ci]: use job-level path filtering so skipped tests pass required checks [CI]: use job-level path filtering so skipped tests pass required checks Mar 23, 2026
Signed-off-by: royyhuang <roy.y.huang@gmail.com>
Copy link
Copy Markdown
Contributor

@sammshen sammshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@royyhuang royyhuang requested a review from deng451e March 23, 2026 21:54
Copy link
Copy Markdown
Collaborator

@deng451e deng451e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sammshen sammshen enabled auto-merge (squash) March 23, 2026 22:41
@ApostaC ApostaC added the full Run comprehensive tests on this PR label Mar 24, 2026
The reusable workflows (test.yml, code_quality_checks.yml) now have a
changes job that needs pull-requests: read for dorny/paths-filter to
query the PR file list. Without this, publish.yml fails with
startup_failure since reusable workflows cannot escalate beyond the
caller's granted permissions.

Signed-off-by: royyhuang <roy.y.huang@gmail.com>
@sammshen sammshen merged commit b67c6e9 into LMCache:dev Mar 25, 2026
75 of 80 checks passed
realAaronWu pushed a commit to realAaronWu/LMCache that referenced this pull request Mar 26, 2026
…cks (LMCache#2855)

fix: update CI workflow configurations

Signed-off-by: royyhuang <roy.y.huang@gmail.com>
deng451e pushed a commit to deng451e/LMCache that referenced this pull request Mar 27, 2026
…cks (LMCache#2855)

fix: update CI workflow configurations

Signed-off-by: royyhuang <roy.y.huang@gmail.com>
jooho-XCENA pushed a commit to xcena-dev/LMCache that referenced this pull request Apr 2, 2026
…cks (LMCache#2855)

fix: update CI workflow configurations

Signed-off-by: royyhuang <roy.y.huang@gmail.com>
jooho-XCENA pushed a commit to xcena-dev/LMCache that referenced this pull request Apr 2, 2026
…cks (LMCache#2855)

fix: update CI workflow configurations

Signed-off-by: royyhuang <roy.y.huang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full Run comprehensive tests on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants