Fix[config]: replace store_true with BooleanOptionalAction for --l1-use-lazy#2761
Fix[config]: replace store_true with BooleanOptionalAction for --l1-use-lazy#2761maobaolong merged 2 commits intoLMCache:devfrom
Conversation
…se-lazy Use argparse.BooleanOptionalAction instead of action='store_true' so that --no-l1-use-lazy can be passed on the command line to explicitly disable lazy loading for L1 memory. Signed-off-by: liuyumoye <adeline_ly2023@outlook.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the command-line interface for LMCache by replacing the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request correctly replaces action="store_true" with action=argparse.BooleanOptionalAction for the --l1-use-lazy argument. This enhancement allows users to explicitly disable lazy loading for L1 memory via the --no-l1-use-lazy command-line flag, improving the flexibility and usability of the configuration options. The change is well-aligned with argparse best practices for boolean flags.
ApostaC
left a comment
There was a problem hiding this comment.
Can we update the docs as well? There is a configuration page for mp mode that talks about the cli args: https://docs.lmcache.ai/mp/configuration.html
Signed-off-by: baoloongmao <baoloongmao@tencent.com>
maobaolong
left a comment
There was a problem hiding this comment.
LGTM. thanks for this improvement.
…se-lazy (LMCache#2761) * fix(config): replace store_true with BooleanOptionalAction for --l1-use-lazy Use argparse.BooleanOptionalAction instead of action='store_true' so that --no-l1-use-lazy can be passed on the command line to explicitly disable lazy loading for L1 memory. Signed-off-by: liuyumoye <adeline_ly2023@outlook.com> * Update doc Signed-off-by: baoloongmao <baoloongmao@tencent.com> --------- Signed-off-by: liuyumoye <adeline_ly2023@outlook.com> Signed-off-by: baoloongmao <baoloongmao@tencent.com> Co-authored-by: liuyumoye <adeline_ly2023@outlook.com> Co-authored-by: baoloongmao <baoloongmao@tencent.com>
…se-lazy (LMCache#2761) * fix(config): replace store_true with BooleanOptionalAction for --l1-use-lazy Use argparse.BooleanOptionalAction instead of action='store_true' so that --no-l1-use-lazy can be passed on the command line to explicitly disable lazy loading for L1 memory. Signed-off-by: liuyumoye <adeline_ly2023@outlook.com> * Update doc Signed-off-by: baoloongmao <baoloongmao@tencent.com> --------- Signed-off-by: liuyumoye <adeline_ly2023@outlook.com> Signed-off-by: baoloongmao <baoloongmao@tencent.com> Co-authored-by: liuyumoye <adeline_ly2023@outlook.com> Co-authored-by: baoloongmao <baoloongmao@tencent.com> Signed-off-by: Aaron Wu <aaron.wu@dell.com>
…se-lazy (LMCache#2761) * fix(config): replace store_true with BooleanOptionalAction for --l1-use-lazy Use argparse.BooleanOptionalAction instead of action='store_true' so that --no-l1-use-lazy can be passed on the command line to explicitly disable lazy loading for L1 memory. Signed-off-by: liuyumoye <adeline_ly2023@outlook.com> * Update doc Signed-off-by: baoloongmao <baoloongmao@tencent.com> --------- Signed-off-by: liuyumoye <adeline_ly2023@outlook.com> Signed-off-by: baoloongmao <baoloongmao@tencent.com> Co-authored-by: liuyumoye <adeline_ly2023@outlook.com> Co-authored-by: baoloongmao <baoloongmao@tencent.com>
…se-lazy (LMCache#2761) * fix(config): replace store_true with BooleanOptionalAction for --l1-use-lazy Use argparse.BooleanOptionalAction instead of action='store_true' so that --no-l1-use-lazy can be passed on the command line to explicitly disable lazy loading for L1 memory. Signed-off-by: liuyumoye <adeline_ly2023@outlook.com> * Update doc Signed-off-by: baoloongmao <baoloongmao@tencent.com> --------- Signed-off-by: liuyumoye <adeline_ly2023@outlook.com> Signed-off-by: baoloongmao <baoloongmao@tencent.com> Co-authored-by: liuyumoye <adeline_ly2023@outlook.com> Co-authored-by: baoloongmao <baoloongmao@tencent.com>
fix(config): replace store_true with BooleanOptionalAction for --l1-use-lazy
Use argparse.BooleanOptionalAction instead of action='store_true' so that --no-l1-use-lazy can be passed on the command line to explicitly disable lazy loading for L1 memory.