[MP] Update the MP docs and pass telemetry config into http_server#2730
Conversation
Signed-off-by: ApostaC <yihua98@uchicago.edu>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating the documentation for the multiprocessing server to incorporate the recently added Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request updates the lmcache.v1.multiprocess documentation to introduce the --engine-type configuration option, allowing users to select between MPCacheEngine and BlendEngineV2 for the cache backend. This change clarifies that the http_server can now support both engine types, rendering the standalone blend_server legacy. The documentation examples are updated to use http_server with the new --engine-type flag. A review comment suggests an improvement to the configuration.rst example, recommending the inclusion of the --http-port argument for the http_server to make the example more complete.
| python3 -m lmcache.v1.multiprocess.server \ | ||
| python3 -m lmcache.v1.multiprocess.http_server \ | ||
| --host 0.0.0.0 \ | ||
| --port 6555 \ |
There was a problem hiding this comment.
Since the example now uses the http_server entry point, it would be more complete and informative to include its specific configuration arguments, like --http-port. This would clarify how to configure the HTTP frontend that this server variant provides.
| --port 6555 \ | |
| --port 6555 \ | |
| --http-port 8000 \ |
Signed-off-by: ApostaC <yihua98@uchicago.edu>
…MCache#2730) * Update docs for engine type * [add] telemetry config pass to http server and blend server Signed-off-by: ApostaC <yihua98@uchicago.edu> Signed-off-by: shaoxiawjc <wjc2800@163.com>
…MCache#2730) * Update docs for engine type * [add] telemetry config pass to http server and blend server Signed-off-by: ApostaC <yihua98@uchicago.edu> Signed-off-by: Aaron Wu <aaron.wu@dell.com>
…MCache#2730) * Update docs for engine type * [add] telemetry config pass to http server and blend server Signed-off-by: ApostaC <yihua98@uchicago.edu>
…MCache#2730) * Update docs for engine type * [add] telemetry config pass to http server and blend server Signed-off-by: ApostaC <yihua98@uchicago.edu>
What this PR does / why we need it:
Documents the
--engine-typeCLI argument introduced in the previous PR (#2722).Adds the telemetry config parsing (introduced in #2696 ) to http server
Special notes for your reviewers:
Docs-only change.
If applicable: