Skip to content

[Misc] Fix failing unit test in blend server#2717

Merged
YaoJiayi merged 1 commit intodevfrom
localdev/fix-blend-flaky
Mar 9, 2026
Merged

[Misc] Fix failing unit test in blend server#2717
YaoJiayi merged 1 commit intodevfrom
localdev/fix-blend-flaky

Conversation

@YaoJiayi
Copy link
Copy Markdown
Collaborator

@YaoJiayi YaoJiayi commented Mar 9, 2026

What this PR does / why we need it:

Special notes for your reviewers:

If applicable:

  • this PR contains user facing changes - docs added
  • this PR contains unit tests

@YaoJiayi
fix tests
5eb174a 
Signed-off-by: YaoJiayi <120040070@link.cuhk.edu.cn>
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented Mar 9, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where a unit test in the blend server was failing. The fix involves adding a missing parameter to a RequestType.LOOKUP call within the test_cb_store_final_v2_then_normal_lookup test case, ensuring the test now passes.

Highlights

  • Bug Fix: This PR addresses a failing unit test in the blend server.
  • Parameter Adjustment: The test_cb_store_final_v2_then_normal_lookup test case was updated to include an additional parameter (1) in the RequestType.LOOKUP call.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Activity
  • The pull request modifies a test case to correct a failing unit test.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a failing unit test by adding a missing parameter to a LOOKUP request. The change is correct and resolves the issue. I have added one suggestion to improve code quality by replacing a magic number with a named constant, which will enhance readability and maintainability.

Comment thread tests/v1/multiprocess/test_blend_server_v2.py
sammshen
sammshen approved these changes Mar 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@sammshen sammshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@YaoJiayi YaoJiayi enabled auto-merge (squash) March 9, 2026 21:24
@github-actions github-actions Bot added the full Run comprehensive tests on this PR label Mar 9, 2026
@YaoJiayi YaoJiayi merged commit ffeb105 into dev Mar 9, 2026
23 of 29 checks passed
@YaoJiayi YaoJiayi deleted the localdev/fix-blend-flaky branch March 10, 2026 17:36
shaoxiawjc pushed a commit to shaoxiawjc/LMCache that referenced this pull request Mar 11, 2026
@YaoJiayi @shaoxiawjc
[Misc] Fix failing unit test in blend server (LMCache#2717)
bc1897a 
fix tests

Signed-off-by: YaoJiayi <120040070@link.cuhk.edu.cn>
Signed-off-by: shaoxiawjc <wjc2800@163.com>
realAaronWu pushed a commit to realAaronWu/LMCache that referenced this pull request Mar 20, 2026
@YaoJiayi
[Misc] Fix failing unit test in blend server (LMCache#2717)
6672d49 
fix tests

Signed-off-by: YaoJiayi <120040070@link.cuhk.edu.cn>
Signed-off-by: Aaron Wu <aaron.wu@dell.com>
jooho-XCENA pushed a commit to xcena-dev/LMCache that referenced this pull request Apr 2, 2026
@YaoJiayi @jooho-XCENA
[Misc] Fix failing unit test in blend server (LMCache#2717)
70272cf 
fix tests

Signed-off-by: YaoJiayi <120040070@link.cuhk.edu.cn>
jooho-XCENA pushed a commit to xcena-dev/LMCache that referenced this pull request Apr 2, 2026
@YaoJiayi @jooho-XCENA
[Misc] Fix failing unit test in blend server (LMCache#2717)
a0f4b38 
fix tests

Signed-off-by: YaoJiayi <120040070@link.cuhk.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Oasis-Git Oasis-Git Oasis-Git approved these changes

@sammshen sammshen sammshen approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

full Run comprehensive tests on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YaoJiayi @Oasis-Git @sammshen