[Chore][Docs] Update docs for MP mode#2708
Conversation
Signed-off-by: ApostaC <yihua98@uchicago.edu>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the documentation for LMCache's multiprocess mode. It replaces an outdated single page with a comprehensive, multi-page section that provides in-depth coverage of various aspects, including architecture, configuration, deployment, and observability. The update aims to provide clearer, more current, and complete guidance for users and developers interacting with the multiprocess caching system. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This is an excellent and comprehensive documentation overhaul for the multiprocess mode. The new structure is logical, and the content is detailed and clear, covering everything from quick starts to deployment and internal architecture. I found one minor inconsistency in an example configuration that could be confusing for users. Otherwise, the new documentation is a fantastic improvement.
|
|
||
| .. code-block:: bash | ||
|
|
||
| kubectl apply -f examples/multi_process/vllm-deployment.yaml |
There was a problem hiding this comment.
There appears to be an inconsistency in the lmcache.mp.host configuration within the referenced examples/multi_process/vllm-deployment.yaml file.
In vllm-deployment.yaml, the host is specified as "tcp://${HOST_IP}". However, other examples in the documentation (like in configuration.rst) specify only the hostname or IP address, without the tcp:// prefix (e.g., "127.0.0.1").
This could be confusing for users and might lead to connection issues depending on how the vLLM client handles the connection string. For consistency across the documentation, it would be best if all examples used the same format. I'd recommend removing the tcp:// prefix from vllm-deployment.yaml to align with the other examples.
Signed-off-by: ApostaC <yihua98@uchicago.edu>
* [Add] new docs for multi-process mode Signed-off-by: ApostaC <yihua98@uchicago.edu> * [Add] docs for mp mode Signed-off-by: ApostaC <yihua98@uchicago.edu> --------- Signed-off-by: ApostaC <yihua98@uchicago.edu> Signed-off-by: shaoxiawjc <wjc2800@163.com>
* [Add] new docs for multi-process mode Signed-off-by: ApostaC <yihua98@uchicago.edu> * [Add] docs for mp mode Signed-off-by: ApostaC <yihua98@uchicago.edu> --------- Signed-off-by: ApostaC <yihua98@uchicago.edu> Signed-off-by: Aaron Wu <aaron.wu@dell.com>
* [Add] new docs for multi-process mode Signed-off-by: ApostaC <yihua98@uchicago.edu> * [Add] docs for mp mode Signed-off-by: ApostaC <yihua98@uchicago.edu> --------- Signed-off-by: ApostaC <yihua98@uchicago.edu>
* [Add] new docs for multi-process mode Signed-off-by: ApostaC <yihua98@uchicago.edu> * [Add] docs for mp mode Signed-off-by: ApostaC <yihua98@uchicago.edu> --------- Signed-off-by: ApostaC <yihua98@uchicago.edu>
What this PR does / why we need it:
Overhauls the multiprocess mode documentation. The old single page (
kv_cache/multiprocess_mode.rst) was outdated — it didn't cover L2 storage, observability/telemetry, the HTTP server variant, hash algorithm selection, or the internal architecture. The "Future Work" section listed items that are already implemented.This PR replaces it with a new top-level "Multiprocess Mode" section (
docs/source/mp/) containing 7 pages:The old page is replaced with a redirect stub (
:orphan:) pointing to the new section.Special notes for your reviewers:
All CLI args and metric names were cross-referenced against the actual source files. Sphinx build succeeds with 0 new warnings.
If applicable: