Fix regression: restore config validate() call in config.py by hlin99 · Pull Request #2690 · LMCache/LMCache

hlin99 · 2026-03-04T14:55:35Z

Fix regression(#2510): Add _update_config_from_env to namespace_extras The _validate_config function at line 504 was not being called after commit 3d88cee because the custom _update_config_from_env method was removed from namespace_extras, causing the config to use the base implementation which doesn't call validate().

This commit:

Adds _update_config_from_env back to namespace_extras
Updates the method to use the new _resolve_config_aliases signature
Adds a regression test to verify validate() is called

The fix ensures that validation logic (like auto-setting save_unfull_chunk for PD mode) is properly executed when configs are updated from env vars.

[ Y ] this PR contains unit tests

Fix regression: Add _update_config_from_env to namespace_extras The _validate_config function at line 504 was not being called after commit 3d88cee because the custom _update_config_from_env method was removed from namespace_extras, causing the config to use the base implementation which doesn't call validate(). This commit: - Adds _update_config_from_env back to namespace_extras - Updates the method to use the new _resolve_config_aliases signature - Adds a regression test to verify validate() is called The fix ensures that validation logic (like auto-setting save_unfull_chunk for PD mode) is properly executed when configs are updated from env vars. Signed-off-by: Tony Lin <tony.lin@intel.com>

hlin99 · 2026-03-04T14:58:15Z

hi @maobaolong would you like to take a look? the regression seems to be introduced by 3d88cee, but i'm not 100% sure if this is intentional. please double confirm. thanks.

gemini-code-assist · 2026-03-04T15:00:29Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a regression that prevented configuration validation from executing when settings were loaded from environment variables. By restoring the custom _update_config_from_env method and updating its internal call to _resolve_config_aliases, the system now correctly applies validation logic, such as auto-setting save_unfull_chunk for PD mode, ensuring consistent and reliable configuration behavior. A dedicated regression test has been added to safeguard against this issue recurring.

Highlights

Restored Config Validation: The _update_config_from_env method has been re-added to namespace_extras, ensuring that the validate() method is correctly called when configurations are updated from environment variables.
Updated Signature: The _update_config_from_env method now uses the new signature for _resolve_config_aliases, passing explicit configuration definitions and aliases.
Regression Test Added: A new unit test test_update_config_from_env_calls_validate has been introduced to specifically verify that config validation occurs when updating from environment variables, preventing future regressions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

lmcache/v1/config.py
- Updated the call to _resolve_config_aliases to include _CONFIG_DEFINITIONS, _CONFIG_ALIASES, and _DEPRECATED_CONFIGS as arguments.
- Ensured the _user_set_keys attribute is initialized if it doesn't exist.
- Added logic to mark configuration keys as user-set when their values are updated from environment variables.
- Re-added _update_config_from_env to the namespace_extras dictionary.
tests/v1/test_config.py
- Introduced test_update_config_from_env_calls_validate to confirm that validate() is invoked during environment variable configuration updates, specifically checking the save_unfull_chunk behavior in PD mode.

Activity

No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request effectively addresses a regression where the validate() method was not being called when updating configuration from environment variables. The fix correctly restores the custom _update_config_from_env method to the LMCacheEngineConfig's namespace and updates its implementation to be consistent with recent changes in the base configuration class. The addition of a regression test is excellent, as it specifically verifies that the validation logic is now triggered as expected. I have one suggestion to improve the maintainability of the new test case.

gemini-code-assist · 2026-03-04T15:02:06Z

+    # Set up environment for PD mode which requires validation
+    os.environ["LMCACHE_ENABLE_PD"] = "true"
+    os.environ["LMCACHE_PD_ROLE"] = "sender"
+    os.environ["LMCACHE_PD_BUFFER_SIZE"] = "1024"
+    os.environ["LMCACHE_PD_BUFFER_DEVICE"] = "cpu"
+    os.environ["LMCACHE_SAVE_UNFULL_CHUNK"] = "false"
+
+    try:
+        # Create a config and update from env
+        config = LMCacheEngineConfig.from_defaults()
+        config.update_config_from_env()
+
+        # If validate() was called, save_unfull_chunk should be auto-set to True
+        # because PD mode requires it (see line 558-564 in config.py)
+        assert config.save_unfull_chunk is True, (
+            "validate() was not called - save_unfull_chunk should be True for PD mode"
+        )
+    finally:
+        # Clean up environment
+        del os.environ["LMCACHE_ENABLE_PD"]
+        del os.environ["LMCACHE_PD_ROLE"]
+        del os.environ["LMCACHE_PD_BUFFER_SIZE"]
+        del os.environ["LMCACHE_PD_BUFFER_DEVICE"]
+        del os.environ["LMCACHE_SAVE_UNFULL_CHUNK"]


The setup and cleanup of environment variables in this test are a bit repetitive. To improve maintainability and reduce duplication, you could define the environment variables in a dictionary and then iterate over it for both setting them up and tearing them down. This would make it easier to add or remove variables in the future, as you'd only need to change them in one place. Using os.environ.pop() in the cleanup is also slightly more robust than del.

# Set up environment for PD mode which requires validation env_vars = { "LMCACHE_ENABLE_PD": "true", "LMCACHE_PD_ROLE": "sender", "LMCACHE_PD_BUFFER_SIZE": "1024", "LMCACHE_PD_BUFFER_DEVICE": "cpu", "LMCACHE_SAVE_UNFULL_CHUNK": "false", } for key, value in env_vars.items(): os.environ[key] = value try: # Create a config and update from env config = LMCacheEngineConfig.from_defaults() config.update_config_from_env() # If validate() was called, save_unfull_chunk should be auto-set to True # because PD mode requires it (see line 558-564 in config.py) assert config.save_unfull_chunk is True, ( "validate() was not called - save_unfull_chunk should be True for PD mode" ) finally: # Clean up environment for key in env_vars: os.environ.pop(key, None)

sammshen

lgtm

hlin99 · 2026-03-09T11:07:43Z

hi @maobaolong , just make sure you're aware of this PR... if you have other solutions, please comments. thx.

maobaolong

LGTM. Thanks for your fix.

…2690) Fix regression: Add _update_config_from_env to namespace_extras The _validate_config function at line 504 was not being called after commit 3d88cee because the custom _update_config_from_env method was removed from namespace_extras, causing the config to use the base implementation which doesn't call validate(). This commit: - Adds _update_config_from_env back to namespace_extras - Updates the method to use the new _resolve_config_aliases signature - Adds a regression test to verify validate() is called The fix ensures that validation logic (like auto-setting save_unfull_chunk for PD mode) is properly executed when configs are updated from env vars. Signed-off-by: Tony Lin <tony.lin@intel.com>

…2690) Fix regression: Add _update_config_from_env to namespace_extras The _validate_config function at line 504 was not being called after commit 3d88cee because the custom _update_config_from_env method was removed from namespace_extras, causing the config to use the base implementation which doesn't call validate(). This commit: - Adds _update_config_from_env back to namespace_extras - Updates the method to use the new _resolve_config_aliases signature - Adds a regression test to verify validate() is called The fix ensures that validation logic (like auto-setting save_unfull_chunk for PD mode) is properly executed when configs are updated from env vars. Signed-off-by: Tony Lin <tony.lin@intel.com> Signed-off-by: Aaron Wu <aaron.wu@dell.com>

…2690) Fix regression: Add _update_config_from_env to namespace_extras The _validate_config function at line 504 was not being called after commit 3d88cee because the custom _update_config_from_env method was removed from namespace_extras, causing the config to use the base implementation which doesn't call validate(). This commit: - Adds _update_config_from_env back to namespace_extras - Updates the method to use the new _resolve_config_aliases signature - Adds a regression test to verify validate() is called The fix ensures that validation logic (like auto-setting save_unfull_chunk for PD mode) is properly executed when configs are updated from env vars. Signed-off-by: Tony Lin <tony.lin@intel.com>

hlin99 mentioned this pull request Mar 4, 2026

fix: PD disaggregation hangs at Decode node #2685

Open

2 tasks

gemini-code-assist Bot reviewed Mar 4, 2026

View reviewed changes

sammshen approved these changes Mar 5, 2026

View reviewed changes

sammshen requested a review from maobaolong March 5, 2026 05:41

JianDan0212 mentioned this pull request Mar 5, 2026

PD Separation hangs at Decode node in v0.3.12 (Works in v0.3.11) #2510

Closed

Merge branch 'dev' into regression_validate

ed42861

hlin99 added 3 commits March 10, 2026 13:37

Merge branch 'dev' into regression_validate

54e891a

Merge branch 'dev' into regression_validate

263737f

Merge branch 'dev' into regression_validate

f9dc5ae

maobaolong approved these changes Mar 13, 2026

View reviewed changes

hlin99 added 2 commits March 13, 2026 18:47

Merge branch 'dev' into regression_validate

24eb5a4

Merge branch 'dev' into regression_validate

61c76c4

maobaolong enabled auto-merge (squash) March 14, 2026 02:28

github-actions Bot added the full Run comprehensive tests on this PR label Mar 14, 2026

Merge branch 'dev' into regression_validate

625e84b

maobaolong merged commit dedea50 into LMCache:dev Mar 15, 2026
25 of 28 checks passed

hlin99 deleted the regression_validate branch March 15, 2026 05:40

rebel-jinhwan mentioned this pull request Apr 11, 2026

[Bug] Missing validate() in env-only config path of lmcache_get_or_create_config #3002

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix regression: restore config validate() call in config.py#2690

Fix regression: restore config validate() call in config.py#2690
maobaolong merged 8 commits intoLMCache:devfrom
hlin99:regression_validate

hlin99 commented Mar 4, 2026 •

edited

Loading

Uh oh!

hlin99 commented Mar 4, 2026

Uh oh!

gemini-code-assist Bot commented Mar 4, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Mar 4, 2026

Uh oh!

sammshen left a comment

Uh oh!

hlin99 commented Mar 9, 2026

Uh oh!

maobaolong left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

hlin99 commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hlin99 commented Mar 4, 2026

Uh oh!

gemini-code-assist Bot commented Mar 4, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

sammshen left a comment

Choose a reason for hiding this comment

Uh oh!

hlin99 commented Mar 9, 2026

Uh oh!

maobaolong left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hlin99 commented Mar 4, 2026 •

edited

Loading