Add Pythonhashseed in quickstart example#2597
Conversation
In the quickstart example, the pythonhashseed was not set. Thus, there would be no External prefix cache hits. Signed-off-by: Jonas M. Kübler <44084297+jmkuebler@users.noreply.github.com>
Summary of ChangesHello @jmkuebler, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the quickstart documentation for centralized KV cache sharing by explicitly addressing a critical configuration requirement. By adding the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a missing PYTHONHASHSEED setting in the quickstart example for centralized KV cache sharing. By adding this environment variable, it ensures consistent hashing across processes, which is essential for cache hits to work as expected. The changes are accurate and improve the documentation and example commands. I've included one minor suggestion to enhance the clarity of the added documentation note.
|
|
||
| This section demonstrates how to share KV cache across multiple vLLM instances using a centralized LMCache server. | ||
|
|
||
| **Important**: For centralized cache sharing (which is cross-process cases), ensure all processes use the same `PYTHONHASHSEED` to keep the hash of the KV cache consistent across processes: ``export PYTHONHASHSEED=0``. |
There was a problem hiding this comment.
For clarity and better grammar, I suggest rephrasing this sentence. The current phrasing (which is cross-process cases) is a bit awkward.
| **Important**: For centralized cache sharing (which is cross-process cases), ensure all processes use the same `PYTHONHASHSEED` to keep the hash of the KV cache consistent across processes: ``export PYTHONHASHSEED=0``. | |
| **Important**: For centralized cache sharing (a cross-process use case), ensure all processes use the same `PYTHONHASHSEED` for consistent KV cache hashing. For example: ``export PYTHONHASHSEED=0``. |
maobaolong
left a comment
There was a problem hiding this comment.
@jmkuebler Thanks for this update. LGTM
|
@maobaolong who else could review this PR so we can get it merged? |
|
@jmkuebler I'd love to merge this PR, but it lack required conditions
@sammshen Would you like to take another look? |
Add Pythonhashseed In the quickstart example, the pythonhashseed was not set. Thus, there would be no External prefix cache hits. Signed-off-by: Jonas M. Kübler <44084297+jmkuebler@users.noreply.github.com>
Add Pythonhashseed In the quickstart example, the pythonhashseed was not set. Thus, there would be no External prefix cache hits. Signed-off-by: Jonas M. Kübler <44084297+jmkuebler@users.noreply.github.com> Signed-off-by: Ofer Kiselov Nahman <ofer.kiselovnahman@weka.io>
Add Pythonhashseed In the quickstart example, the pythonhashseed was not set. Thus, there would be no External prefix cache hits. Signed-off-by: Jonas M. Kübler <44084297+jmkuebler@users.noreply.github.com>
Add Pythonhashseed In the quickstart example, the pythonhashseed was not set. Thus, there would be no External prefix cache hits. Signed-off-by: Jonas M. Kübler <44084297+jmkuebler@users.noreply.github.com>
Add Pythonhashseed In the quickstart example, the pythonhashseed was not set. Thus, there would be no External prefix cache hits. Signed-off-by: Jonas M. Kübler <44084297+jmkuebler@users.noreply.github.com> Signed-off-by: shaoxiawjc <wjc2800@163.com>
Add Pythonhashseed In the quickstart example, the pythonhashseed was not set. Thus, there would be no External prefix cache hits. Signed-off-by: Jonas M. Kübler <44084297+jmkuebler@users.noreply.github.com> Signed-off-by: Aaron Wu <aaron.wu@dell.com>
Add Pythonhashseed In the quickstart example, the pythonhashseed was not set. Thus, there would be no External prefix cache hits. Signed-off-by: Jonas M. Kübler <44084297+jmkuebler@users.noreply.github.com>
Add Pythonhashseed In the quickstart example, the pythonhashseed was not set. Thus, there would be no External prefix cache hits. Signed-off-by: Jonas M. Kübler <44084297+jmkuebler@users.noreply.github.com>
In the quickstart example, the pythonhashseed was not set. Thus, there would be no External prefix cache hits.