Support database option at Valkey connector by bluayer · Pull Request #2307 · LMCache/LMCache

bluayer · 2025-12-24T15:30:16Z

What this PR does / why we need it:
Valkey 9.0 now supports cluster-mode numbered databases, just like in standalone mode. This PR is to support this(numbered database) in LMCache as well.

Special notes for your reviewers:

If applicable:

this PR contains user facing changes - docs added
this PR contains unit tests

gemini-code-assist · 2025-12-24T15:30:29Z

Summary of Changes

Hello @bluayer, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the LMCache Valkey connector to support numbered databases, a feature recently introduced in Valkey 9.0 and Valkey-GLIDE 2.1+. This change allows users to specify a database ID in their Valkey cluster configurations, providing greater flexibility and control over data organization within the Valkey environment.

Highlights

Valkey Database Support: The Valkey connector now supports numbered databases, aligning with new capabilities in Valkey 9.0+ and Valkey-GLIDE 2.1+.
Configuration Update: The ValkeyConnector class has been updated to accept an optional database_id parameter, which is then passed to the GlideClusterClientConfiguration.
Documentation Added: New documentation has been added to docs/source/kv_cache/storage_backends/valkey.rst demonstrating how to configure Valkey with numbered databases in cluster mode.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request adds support for numbered databases in the Valkey cluster connector, which is a useful feature enhancement. The changes correctly update the connector logic and the documentation. I have two suggestions to improve the implementation's robustness and maintainability. One is a high-severity recommendation to refactor the connector adapter to be stateless, preventing potential configuration bugs. The other is a medium-severity suggestion to improve consistency in how the database ID is handled during client configuration.

DongDongJu

LGTM,
Could you add the some more description in doc difference among the cluster modes?(nodes, endpoint, databases)

bluayer · 2025-12-31T05:36:00Z

Thank you for your time, @DongDongJu.
I added description in doc about differences of configurations for cluster-mode.

bluayer · 2026-02-26T23:42:25Z

Hi, @DongDongJu and @sammshen.

I know you're busy, so I apologize for the mention. When you have a moment, could you let me know if there's anything else I should address to help move the PR review forward?

sammshen

LGTM!

DongDongJu

LGTM. Thanks for revise.

Signed-off-by: Jungwoo Song <bluayer@gmail.com>

bluayer · 2026-03-11T23:38:01Z

Could my code be causing the CI failure? I'm not sure what the cause is...

* feat: support clsuter-mode numbered databases Signed-off-by: Jungwoo Song <bluayer@gmail.com> * docs: for numbered database Signed-off-by: Jungwoo Song <bluayer@gmail.com> * docs: add desc for cluster-mode and numbered databases Signed-off-by: Jungwoo Song <bluayer@gmail.com> --------- Signed-off-by: Jungwoo Song <bluayer@gmail.com>

* feat: support clsuter-mode numbered databases Signed-off-by: Jungwoo Song <bluayer@gmail.com> * docs: for numbered database Signed-off-by: Jungwoo Song <bluayer@gmail.com> * docs: add desc for cluster-mode and numbered databases Signed-off-by: Jungwoo Song <bluayer@gmail.com> --------- Signed-off-by: Jungwoo Song <bluayer@gmail.com> Signed-off-by: Aaron Wu <aaron.wu@dell.com>

* feat: support clsuter-mode numbered databases Signed-off-by: Jungwoo Song <bluayer@gmail.com> * docs: for numbered database Signed-off-by: Jungwoo Song <bluayer@gmail.com> * docs: add desc for cluster-mode and numbered databases Signed-off-by: Jungwoo Song <bluayer@gmail.com> --------- Signed-off-by: Jungwoo Song <bluayer@gmail.com>

bluayer force-pushed the feature/valkey-numbered-databases branch from 944fd91 to 826a949 Compare December 24, 2025 15:31

gemini-code-assist Bot reviewed Dec 24, 2025

View reviewed changes

Comment thread lmcache/v1/storage_backend/connector/valkey_adapter.py

Comment thread lmcache/v1/storage_backend/connector/valkey_connector.py

DongDongJu reviewed Dec 29, 2025

View reviewed changes

sammshen approved these changes Mar 4, 2026

View reviewed changes

DongDongJu approved these changes Mar 4, 2026

View reviewed changes

DongDongJu enabled auto-merge (squash) March 4, 2026 18:20

github-actions Bot added the full Run comprehensive tests on this PR label Mar 4, 2026

bluayer added 3 commits March 11, 2026 17:22

feat: support clsuter-mode numbered databases

7b415fd

Signed-off-by: Jungwoo Song <bluayer@gmail.com>

docs: for numbered database

fc6b702

Signed-off-by: Jungwoo Song <bluayer@gmail.com>

docs: add desc for cluster-mode and numbered databases

63386fa

Signed-off-by: Jungwoo Song <bluayer@gmail.com>

auto-merge was automatically disabled March 11, 2026 08:22
Head branch was pushed to by a user without write access

bluayer force-pushed the feature/valkey-numbered-databases branch from 9101e04 to 63386fa Compare March 11, 2026 08:22

github-actions Bot removed the full Run comprehensive tests on this PR label Mar 11, 2026

sammshen enabled auto-merge (squash) March 16, 2026 05:39

github-actions Bot added the full Run comprehensive tests on this PR label Mar 16, 2026

sammshen merged commit d6661f1 into LMCache:dev Mar 16, 2026
29 of 30 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support database option at Valkey connector #2307

Support database option at Valkey connector #2307
sammshen merged 3 commits intoLMCache:devfrom
bluayer:feature/valkey-numbered-databases

bluayer commented Dec 24, 2025 •

edited

Loading

Uh oh!

gemini-code-assist Bot commented Dec 24, 2025

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

DongDongJu left a comment

Uh oh!

bluayer commented Dec 31, 2025

Uh oh!

bluayer commented Feb 26, 2026

Uh oh!

sammshen left a comment

Uh oh!

DongDongJu left a comment

Uh oh!

bluayer commented Mar 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

bluayer commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot commented Dec 24, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

DongDongJu left a comment

Choose a reason for hiding this comment

Uh oh!

bluayer commented Dec 31, 2025

Uh oh!

bluayer commented Feb 26, 2026

Uh oh!

sammshen left a comment

Choose a reason for hiding this comment

Uh oh!

DongDongJu left a comment

Choose a reason for hiding this comment

Uh oh!

bluayer commented Mar 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bluayer commented Dec 24, 2025 •

edited

Loading