[refactor] move get_shapes to LMCacheEngineMetadata#2284
[refactor] move get_shapes to LMCacheEngineMetadata#2284chunxiaozheng merged 2 commits intoLMCache:devfrom
Conversation
Summary of ChangesHello @chunxiaozheng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the KV cache shape determination logic by relocating the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a well-executed refactoring that moves the get_shapes logic to LMCacheEngineMetadata, which is a more logical location for it. The changes are consistent across all modified files and improve the code structure. I have one suggestion to improve the clarity of a variable name in the new get_shapes method.
ApostaC
left a comment
There was a problem hiding this comment.
One quick question. Otherwise LGTM
| layers = group.num_layers | ||
| num_heads = 1 if self.use_mla else group.shape[3] | ||
| hidden_dim_size = num_heads * group.shape[-1] |
There was a problem hiding this comment.
Dumb question: Will similar logic be used multiple times when we use kv_layer_groups in different places? If so, we can probably implement them as some methods in the kv_layer_group class.
There was a problem hiding this comment.
@ApostaC Good idea, this is a common attribute of kv_layer_group, I have updated!
Signed-off-by: idellzheng <idellzheng@tencent.com>
* [refactor] move get_shapes to LMCacheEngineMetadata Signed-off-by: idellzheng <idellzheng@tencent.com> * update Signed-off-by: idellzheng <idellzheng@tencent.com> --------- Signed-off-by: idellzheng <idellzheng@tencent.com>
* [refactor] move get_shapes to LMCacheEngineMetadata Signed-off-by: idellzheng <idellzheng@tencent.com> * update Signed-off-by: idellzheng <idellzheng@tencent.com> --------- Signed-off-by: idellzheng <idellzheng@tencent.com>
move
get_shapesfromgpu_connectortometadata, it is convenient for us to use in other places, such asLocalCPUBackendandRemoteConnector.In addition, this can help us remove some methods in
gpu_connector, such asinit_group_info.