BUG: Servers create Firewalls Request Option should not get json encoded#99
Merged
LKaemmerling merged 1 commit intoLKDevelopment:masterfrom May 9, 2023
Merged
Conversation
…n encoded The whole Request seems to be json encoded - the API throws an error if the firewall option is json encoded before
LKaemmerling
approved these changes
May 9, 2023
Collaborator
|
Good catch! Thank you! |
BenjaminLeibinger
added a commit
to BenjaminLeibinger/hetzner-cloud-php-sdk
that referenced
this pull request
Jun 8, 2023
osthafen
added a commit
to osthafen/hetzner-cloud-php-sdk
that referenced
this pull request
Jun 14, 2023
same Bug as in LKDevelopment#99
LKaemmerling
pushed a commit
that referenced
this pull request
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The whole Request seems to be json encoded - the API throws an error if the firewall option is json encoded before